Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace type Any for constructor in all tests #962

Merged
merged 9 commits into from
Sep 13, 2024

Conversation

raisadz
Copy link
Contributor

@raisadz raisadz commented Sep 13, 2024

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

  • Related issue #
  • Closes #

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below.

@raisadz raisadz force-pushed the replace-constructor-type branch from a41e2e2 to 6522c1d Compare September 13, 2024 10:09
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so nice 😻

@MarcoGorelli MarcoGorelli merged commit 7214060 into narwhals-dev:main Sep 13, 2024
22 checks passed
@raisadz raisadz deleted the replace-constructor-type branch November 7, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants