Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: xfail cuDF tests for join_asof #959

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

LiamConnors
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below.

cuDF doesn't have merge_asof, meaning the following tests fail:

FAILED tests/frame/join_test.py::test_joinasof_numeric[cudf_constructor] - AttributeError: module 'cudf' has no attribute 'merge_asof'
FAILED tests/frame/join_test.py::test_joinasof_time[cudf_constructor] - AttributeError: module 'cudf' has no attribute 'merge_asof'
FAILED tests/frame/join_test.py::test_joinasof_by[cudf_constructor] - AttributeError: module 'cudf' has no attribute 'merge_asof'

There's already an issue open for it rapidsai/cudf#2231

Copy link
Member

@FBruzzesi FBruzzesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LiamConnors πŸ™ŒπŸΌ

NarwhalsKittyGIF

@FBruzzesi FBruzzesi merged commit fc6fb53 into narwhals-dev:main Sep 13, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants