Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: fix an issue with string keys in left and semi joins in Dask, add Dask to tpch benchmarks #957

Merged
merged 9 commits into from
Sep 12, 2024

Conversation

raisadz
Copy link
Contributor

@raisadz raisadz commented Sep 12, 2024

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

  • Related issue #
  • Closes #

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below.

  • Fix an issue with string keys in left and semi joins in Dask;
  • Added an error message of Expr.unique is not supported for the Dask backend as it modifies the index;
  • Added Dask to tpch benchmarks;

Copy link
Member

@FBruzzesi FBruzzesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, and adjusting the tpch queries to handle the dask unique case.

I left a major comment that will need to be addressed though πŸ˜‡

narwhals/_dask/dataframe.py Outdated Show resolved Hide resolved
Copy link
Member

@FBruzzesi FBruzzesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @raisadz πŸ™ŒπŸΌ

NarwhalChubbiwhalGIF

@FBruzzesi FBruzzesi merged commit 8d4c658 into narwhals-dev:main Sep 12, 2024
22 checks passed
@MarcoGorelli
Copy link
Member

awesome work here, thanks both! πŸ™Œ

@raisadz raisadz deleted the tpch-add-dask branch November 7, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants