fix: Update copy param on to_numpy to default to True for cuDF
#937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
thanks @LiamConnors !
agree - we don't expose copy in to_numpy anyway (https://narwhals-dev.github.io/narwhals/api-reference/series/#narwhals.series.Series.to_numpy) so 👍 to just use the library's default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.
This PR fixes issue seen in tests:
ValueError: copy=False is not supported because conversion to a numpy array always copies the data.And reduces the number of failing tests by 7.
@MarcoGorelli the cuDF docs show
copydefaults toTrueon cuDF. So I think that it should setcopy=Truehere when it'sNonefor cuDF. What do you think - Is that the right approach?https://docs.rapids.ai/api/cudf/stable/user_guide/api_docs/api/cudf.series.to_numpy/
https://docs.rapids.ai/api/cudf/stable/user_guide/api_docs/api/cudf.dataframe.to_numpy/