Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #818

Merged
merged 3 commits into from
Sep 7, 2024

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Aug 19, 2024

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 064f76f to aa5817c Compare August 19, 2024 19:48
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 9d3d7ef to a998e69 Compare August 26, 2024 19:55
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.5.7 → v0.6.3](astral-sh/ruff-pre-commit@v0.5.7...v0.6.3)
- [github.com/pre-commit/mirrors-mypy: v1.11.1 → v1.11.2](pre-commit/mirrors-mypy@v1.11.1...v1.11.2)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 9681309 to 80561f9 Compare September 2, 2024 19:44
@EdAbati
Copy link
Collaborator

EdAbati commented Sep 3, 2024

@MarcoGorelli FYI I saw that there were some errors here.

I have updated the code in the notebook where (I think) it made sense, and mostly ingnored the ruff rules for tpch/notebook

I think should be ok to merge now 👀

@EdAbati
Copy link
Collaborator

EdAbati commented Sep 3, 2024

Ah I just saw the effort for refactoring the tpch/notebook (that for some reason I didn't notice before)

Maybe we can wait until all the queries are done, so this diff gets smaller

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @EdAbati for fixing it up!

@MarcoGorelli MarcoGorelli merged commit 5f91aa1 into main Sep 7, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants