Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor root_names and output_names tracking #1731

Merged
merged 3 commits into from
Jan 5, 2025

Conversation

EdAbati
Copy link
Collaborator

@EdAbati EdAbati commented Jan 5, 2025

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

  • Related issue #<issue number>
  • Closes #<issue number>

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

I saw this code repeated multiple times, I think we can put it in a function :)

@MarcoGorelli
Copy link
Member

love this 😍

@EdAbati EdAbati marked this pull request as ready for review January 5, 2025 20:00
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @EdAbati !

@MarcoGorelli MarcoGorelli merged commit 03f6754 into narwhals-dev:main Jan 5, 2025
23 checks passed
@EdAbati EdAbati deleted the infer-root-output-names branch January 5, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants