Skip to content

Commit

Permalink
xfail to_arrow tests for cuDF
Browse files Browse the repository at this point in the history
  • Loading branch information
LiamConnors committed Sep 7, 2024
1 parent b32fd4a commit d695efd
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
2 changes: 2 additions & 0 deletions tests/frame/to_arrow_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ def test_to_arrow(request: Any, constructor_eager: Any) -> None:
if "pandas" in str(constructor_eager) and parse_version(pd.__version__) < (1, 0, 0):
# pyarrow requires pandas>=1.0.0
request.applymarker(pytest.mark.xfail)
if "cudf" in str(constructor_eager):
request.applymarker(pytest.mark.xfail)

data = {"a": [1, 3, 2], "b": [4, 4, 6], "z": [7.1, 8, 9]}
df_raw = constructor_eager(data)
Expand Down
11 changes: 8 additions & 3 deletions tests/series_only/to_arrow_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@
import narwhals.stable.v1 as nw


def test_to_arrow(constructor_eager: Any) -> None:
def test_to_arrow(constructor_eager: Any, request: Any) -> None:
if "cudf" in str(constructor_eager):
request.applymarker(pytest.mark.xfail)

data = [1, 2, 3]
result = nw.from_native(constructor_eager({"a": data}), eager_only=True)[
"a"
Expand All @@ -20,8 +23,10 @@ def test_to_arrow(constructor_eager: Any) -> None:


def test_to_arrow_with_nulls(constructor_eager: Any, request: Any) -> None:
if "pandas_constructor" in str(constructor_eager) or "modin_constructor" in str(
constructor_eager
if (
"pandas_constructor" in str(constructor_eager)
or "modin_constructor" in str(constructor_eager)
or "cudf" in str(constructor_eager)
):
request.applymarker(pytest.mark.xfail)

Expand Down

0 comments on commit d695efd

Please sign in to comment.