test: Unxfail 2 modin tests (#870)

* fix: is_first_distinct for modin/cudf

* remove xfail

narwhals/_pandas_like/series.py

@@ -527,10 +527,14 @@ def null_count(self: Self) -> int:
         return self._native_series.isna().sum()  # type: ignore[no-any-return]
 
     def is_first_distinct(self: Self) -> Self:
-        return self._from_native_series(~self._native_series.duplicated(keep="first"))
+        res = ~self._native_series.duplicated(keep="first")
+        res = self._rename(res, self.name)
+        return self._from_native_series(res)
 
     def is_last_distinct(self: Self) -> Self:
-        return self._from_native_series(~self._native_series.duplicated(keep="last"))
+        res = ~self._native_series.duplicated(keep="last")
+        res = self._rename(res, self.name)
+        return self._from_native_series(res)
 
     def is_sorted(self: Self, *, descending: bool = False) -> bool:
         if not isinstance(descending, bool):

tests/expr_and_series/is_first_distinct_test.py

@@ -1,7 +1,5 @@
 from typing import Any
 
-import pytest
-
 import narwhals.stable.v1 as nw
 from tests.utils import compare_dicts
 
@@ -11,10 +9,7 @@
 }
 
 
-def test_is_first_distinct_expr(constructor: Any, request: Any) -> None:
-    if "modin" in str(constructor):
-        # TODO(unassigned): why is Modin failing here?
-        request.applymarker(pytest.mark.xfail)
+def test_is_first_distinct_expr(constructor: Any) -> None:
     df = nw.from_native(constructor(data))
     result = df.select(nw.all().is_first_distinct())
     expected = {

tests/expr_and_series/is_last_distinct_test.py

@@ -1,7 +1,5 @@
 from typing import Any
 
-import pytest
-
 import narwhals.stable.v1 as nw
 from tests.utils import compare_dicts
 
@@ -11,10 +9,7 @@
 }
 
 
-def test_is_last_distinct_expr(constructor: Any, request: Any) -> None:
-    if "modin" in str(constructor):
-        # TODO(unassigned): why is Modin failing here?
-        request.applymarker(pytest.mark.xfail)
+def test_is_last_distinct_expr(constructor: Any) -> None:
     df = nw.from_native(constructor(data))
     result = df.select(nw.all().is_last_distinct())
     expected = {