feat: implement to_arrow for cuDF (#924)

* xfail to_arrow tests for cuDF * Revert "xfail to_arrow tests for cuDF" This reverts commit d695efd. * implement to_arrow for cuDF
narwhals-dev · Sep 9, 2024 · 7bfb776 · 7bfb776
1 parent 693d53a
commit 7bfb776
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/narwhals/_pandas_like/dataframe.py b/narwhals/_pandas_like/dataframe.py
@@ -672,8 +672,7 @@ def gather_every(self: Self, n: int, offset: int = 0) -> Self:
 
     def to_arrow(self: Self) -> Any:
         if self._implementation is Implementation.CUDF:  # pragma: no cover
-            msg = "`to_arrow` is not implemented for CuDF backend."
-            raise NotImplementedError(msg)
+            return self._native_frame.to_arrow(preserve_index=False)
 
         import pyarrow as pa  # ignore-banned-import()
 

diff --git a/narwhals/_pandas_like/series.py b/narwhals/_pandas_like/series.py
@@ -635,8 +635,7 @@ def clip(
 
     def to_arrow(self: Self) -> Any:
         if self._implementation is Implementation.CUDF:  # pragma: no cover
-            msg = "`to_arrow` is not implemented for CuDF backend."
-            raise NotImplementedError(msg)
+            return self._native_series.to_arrow()
 
         import pyarrow as pa  # ignore-banned-import()