change the order of getitem str and Sequence[str]

narwhals-dev · Sep 9, 2024 · 27966d9 · 27966d9
1 parent 6653789
commit 27966d9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/narwhals/dataframe.py b/narwhals/dataframe.py
@@ -610,10 +610,10 @@ def __getitem__(self, item: tuple[Sequence[int], int]) -> Series: ...  # type: i
     def __getitem__(self, item: Sequence[int]) -> Self: ...
 
     @overload
-    def __getitem__(self, item: Sequence[str]) -> Self: ...
+    def __getitem__(self, item: str) -> Series: ...  # type: ignore[overload-overlap]
 
     @overload
-    def __getitem__(self, item: str) -> Series: ...  # type: ignore[misc]
+    def __getitem__(self, item: Sequence[str]) -> Self: ...
 
     @overload
     def __getitem__(self, item: slice) -> Self: ...

diff --git a/narwhals/stable/v1.py b/narwhals/stable/v1.py
@@ -92,9 +92,9 @@ def __getitem__(self, item: tuple[Sequence[int], int]) -> Series: ...  # type: i
     @overload
     def __getitem__(self, item: Sequence[int]) -> Self: ...
     @overload
-    def __getitem__(self, item: Sequence[str]) -> Self: ...
+    def __getitem__(self, item: str) -> Series: ...  # type: ignore[overload-overlap]
     @overload
-    def __getitem__(self, item: str) -> Series: ...  # type: ignore[misc]
+    def __getitem__(self, item: Sequence[str]) -> Self: ...
 
     @overload
     def __getitem__(self, item: slice) -> Self: ...