feat: add Series|Expr.rank
#9278
Annotations
2 errors and 1 warning
Run release-drafter/release-drafter@v6
Validation Failed: {"resource":"Release","code":"invalid","field":"target_commitish"}
{
name: 'HttpError',
id: '12648596029',
status: 422,
response: {
url: 'https://api.github.com/repos/narwhals-dev/narwhals/releases/191688968',
status: 422,
headers: {
'access-control-allow-origin': '*',
'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
connection: 'close',
'content-length': '210',
'content-security-policy': "default-src 'none'",
'content-type': 'application/json; charset=utf-8',
date: 'Tue, 07 Jan 2025 09:17:13 GMT',
'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
server: 'github.com',
'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
vary: 'Accept-Encoding, Accept, X-Requested-With',
'x-accepted-github-permissions': 'contents=write',
'x-content-type-options': 'nosniff',
'x-frame-options': 'deny',
'x-github-api-version-selected': '2022-11-28',
'x-github-media-type': 'github.v3; format=json',
'x-github-request-id': '1047:1D2F2E:1A1FB1B:340D5B3:677CF119',
'x-ratelimit-limit': '5000',
'x-ratelimit-remaining': '4889',
'x-ratelimit-reset': '1736244500',
'x-ratelimit-resource': 'core',
'x-ratelimit-used': '111',
'x-xss-protection': '0'
},
data: {
message: 'Validation Failed',
errors: [
{
resource: 'Release',
code: 'invalid',
field: 'target_commitish'
}
],
documentation_url: 'https://docs.github.com/rest/releases/releases#update-a-release',
status: '422'
}
},
request: {
method: 'PATCH',
url: 'https://api.github.com/repos/narwhals-dev/narwhals/releases/191688968',
headers: {
accept: 'application/vnd.github.v3+json',
'user-agent': 'probot/12.2.5 octokit-core.js/3.5.1 Node.js/20.18.0 (linux; x64)',
authorization: 'token [REDACTED]',
'content-type': 'application/json; charset=utf-8'
},
body: '{"body":"## Changes\\n\\n## 📖 Documentation\\n\\n- docs: update api-completeness with `duckdb` (#1740)\\n\\n## 🛠️ Other improvements\\n\\n- chore: filter old pyarrow/pandas warnings we cant do anything about (#1746)\\n- [pre-commit.ci] pre-commit autoupdate (#1741)\\n\\nThank you to all our contributors for making this release possible!\\n@AlessandroMiola, @EdAbati, @FBruzzesi, @MarcoGorelli, @anopsy, @pre-commit-ci and @pre-commit-ci[bot]\\n","draft":true,"prerelease":false,"make_latest":"true","name":"Narwhals unreleased","tag_name":"untagged-687e32e724ca1018ab08","target_commitish":"refs/pull/1342/merge"}',
request: {}
},
event: {
id: '12648596029',
name: 'pull_request',
payload: {
action: 'edited',
changes: {
body: {
from: '## What type of PR is this? (check all applicable)\r\n' +
'\r\n' +
'- [ ] 💾 Refactor\r\n' +
'- [x] ✨ Feature\r\n' +
'- [ ] 🐛 Bug Fix\r\n' +
'- [ ] 🔧 Optimization\r\n' +
'- [ ] 📝 Documentation\r\n' +
'- [ ] ✅ Test\r\n' +
'- [ ] 🐳 Other\r\n' +
'\r\n' +
'## Related issues \r\n' +
'\r\n' +
'- Related issue #1323 \r\n' +
'\r\n' +
'## Checklist\r\n' +
'\r\n' +
'- [x] Code follows style guide (ruff)\r\n' +
'- [x] Tests added \r\n' +
'- [x] Documented the changes\r\n' +
'\r\n' +
'## If you have comments or can explain your changes, please do so below.\r\n' +
'\r\n' +
'This PR provides initial support for rank method. I will start it as a draft due to a bunch of shortcomings:\r\n' +
'\r\n'
|
Run release-drafter/release-drafter@v6
HttpError: Validation Failed: {"resource":"Release","code":"invalid","field":"target_commitish"}
at /home/runner/work/_actions/release-drafter/release-drafter/v6/dist/index.js:8462:21
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async Job.doExecute (/home/runner/work/_actions/release-drafter/release-drafter/v6/dist/index.js:30793:18)
{
name: 'AggregateError',
event: {
id: '12648596029',
name: 'pull_request',
payload: {
action: 'edited',
changes: {
body: {
from: '## What type of PR is this? (check all applicable)\r\n' +
'\r\n' +
'- [ ] 💾 Refactor\r\n' +
'- [x] ✨ Feature\r\n' +
'- [ ] 🐛 Bug Fix\r\n' +
'- [ ] 🔧 Optimization\r\n' +
'- [ ] 📝 Documentation\r\n' +
'- [ ] ✅ Test\r\n' +
'- [ ] 🐳 Other\r\n' +
'\r\n' +
'## Related issues \r\n' +
'\r\n' +
'- Related issue #1323 \r\n' +
'\r\n' +
'## Checklist\r\n' +
'\r\n' +
'- [x] Code follows style guide (ruff)\r\n' +
'- [x] Tests added \r\n' +
'- [x] Documented the changes\r\n' +
'\r\n' +
'## If you have comments or can explain your changes, please do so below.\r\n' +
'\r\n' +
'This PR provides initial support for rank method. I will start it as a draft due to a bunch of shortcomings:\r\n' +
'\r\n' +
'- **pandas**:\r\n' +
" - there is a (nasty) trick to make it work with nulls/nans and nullable dtypes (related: to [BUG: rank does not respect na_option='keep' for numpy nullable integer dtypes](https://github.com/pandas-dev/pandas/issues/56976), which should be fixed in pandas 3) - I will comment the trick in the code\r\n" +
' - support in `over` context is available\r\n' +
' - support in `group_by` context is not available.\r\n' +
'- **pyarrow**:\r\n' +
' - does not support polars default method (namely, "average"), therefore if rank is called without specifying another method, it will end up raising an error\r\n' +
' - does not implement rank in a group by context\r\n' +
' - I am using `pyarrow.compute.rank` which is available but not exposed/documented (?)\r\n' +
'- **dask**: it just does not support ranking\r\n' +
'- **polars**: \r\n' +
' - group by context _always_ returns an aggregate, in this case a list of ranks - which is fairly useless as it is a list of increasing/descreasing range until the size of the group\r\n'
}
},
number: 1342,
organization: {
avatar_url: 'https://avatars.githubusercontent.com/u/169070048?v=4',
description: 'Narwhals developers',
events_url: 'https://api.github.com/orgs/narwhals-dev/events',
hooks_url: 'https://api.github.com/orgs/narwhals-dev/hooks',
id: 169070048,
issues_url: 'https://api.github.com/orgs/narwhals-dev/issues',
login: 'narwhals-dev',
members_url: 'https://api.github.com/orgs/narwhals-dev/members{/member}',
node_id: 'O_kgDOChPN4A',
public_members_url: 'https://api.github.com/orgs/narwhals-dev/public_members{/member}',
repos_url: 'https://api.github.com/orgs/narwhals-dev/repos',
url: 'https://api.github.com/orgs/narwhals-dev'
},
pull_request: {
_links: {
comments: {
href: 'https://api.github.com/repos/narwhals-dev/narwhals/issues/1342/comments'
},
commits: {
href: 'https://api.github.com/repos/narwhals-dev/narwhals/pulls/1342/commits'
},
html: {
href: 'https://github.com/narwhals-dev/narwhals/pull/1342'
},
issue: {
href: 'https://api.github.com/repos/narwhals-dev/narwhals/issues/1342'
},
review_comment: {
href: 'https://api.github.co
|
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Loading