Add API tokens and a unique exception #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narugo1992
requested review from
narugo1992
and removed request for
narugo1992
narugo1992
requested changes
Jan 20, 2025
| @@ -51,6 +51,12 @@ def download_file(url, filename, expected_size: int = None, desc=None, session=N | |||
| :rtype: str | |||
| """ | |||
| session = session or requests.session() | |||
|
|
|||
| if "CIVITAI_API_TOKEN" in os.environ: | |||
| url = url + ("&" if "?" in url else "?") + "token=" + os.environ['CIVITAI_API_TOKEN'] | |||
There was a problem hiding this comment.
i suggest we can use the http header to do the authorization, instead of modifying the url by string operations.
https://github.com/civitai/civitai/wiki/REST-API-Reference#authorization
| if "CIVITAI_API_TOKEN" in os.environ: | ||
| url = url + ("&" if "?" in url else "?") + "token=" + os.environ['CIVITAI_API_TOKEN'] | ||
| else: | ||
| print("No token found.") |
There was a problem hiding this comment.
hmmm, do not directly print this, log this with low levels (like debug/info)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.