[GPU] Add missing sensors for mac mini m1 #20
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @narugit,
Hope you're doing well. Unfortunately while doing xbmc/xbmc#23770 I found out the gpu temperature tests are failing on our CI. The CI runs on mac minis (M1 CPU).
Runtime testing it (
smctemp -l
) I figure out those must be the two sensors reported by TGPro for the GPU (they are even the only ones starting withTg
). Interesting stuff - the OS only seems to report data to those sensors when the GPU is under load (otherwise it reports 0.0). TGPro, when the GPU doesn't have any load reports a static 30.0ºC which also matches the average temperature of the machine (the overall sensors the app has combined). So this pretty much indicates they are also using the same strategy smctemp is doing but simply use a fallback temperature when there's no data.When the GPU is under load the temperature match the one reported by TGPro pretty close!