Limit list to namespace objects

Similar issue to qjob, namespace was passed but not used. [#165900520](https://www.pivotaltracker.com/story/show/165900520)
napelvs · May 14, 2020 · 02fae54 · 02fae54
1 parent d09bff9
commit 02fae54
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/pkg/kube/controllers/quarkslink/pod_mutator.go b/pkg/kube/controllers/quarkslink/pod_mutator.go
@@ -50,6 +50,7 @@ func (m *PodMutator) Handle(ctx context.Context, req admission.Request) admissio
 	if err != nil {
 		return admission.Errored(http.StatusBadRequest, err)
 	}
+	m.log.Debugf("Pod mutator handler ran for pod '%s/%s' (%s)", pod.Namespace, pod.Name, req.Namespace)
 
 	updatedPod := pod.DeepCopy()
 	if validEntanglement(pod.GetAnnotations()) {

diff --git a/pkg/kube/controllers/quarksstatefulset/pod_mutator.go b/pkg/kube/controllers/quarksstatefulset/pod_mutator.go
@@ -46,7 +46,7 @@ func (m *PodMutator) Handle(ctx context.Context, req admission.Request) admissio
 	if err != nil {
 		return admission.Errored(http.StatusBadRequest, err)
 	}
-	m.log.Debugf("Pod mutator handler ran for pod '%s/%s'", pod.Namespace, pod.Name)
+	m.log.Debugf("Pod mutator handler ran for pod '%s/%s' (%s)", pod.Namespace, pod.Name, req.Namespace)
 
 	updatedPod := pod.DeepCopy()
 	if isQuarksStatefulSet(pod.GetLabels()) {

diff --git a/pkg/kube/util/reference/reconciles.go b/pkg/kube/util/reference/reconciles.go
@@ -175,7 +175,7 @@ func SkipReconciles(ctx context.Context, client crc.Client, object apis.Object)
 
 func listBOSHDeployments(ctx context.Context, client crc.Client, namespace string) (*bdv1.BOSHDeploymentList, error) {
 	result := &bdv1.BOSHDeploymentList{}
-	err := client.List(ctx, result)
+	err := client.List(ctx, result, crc.InNamespace(namespace))
 	if err != nil {
 		return nil, errors.Wrap(err, "failed to list BOSHDeployments")
 	}
@@ -185,7 +185,7 @@ func listBOSHDeployments(ctx context.Context, client crc.Client, namespace strin
 
 func listQuarksStatefulSets(ctx context.Context, client crc.Client, namespace string) (*qstsv1a1.QuarksStatefulSetList, error) {
 	result := &qstsv1a1.QuarksStatefulSetList{}
-	err := client.List(ctx, result)
+	err := client.List(ctx, result, crc.InNamespace(namespace))
 	if err != nil {
 		return nil, errors.Wrap(err, "failed to list QuarksStatefulSets")
 	}