-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update url for fetching plugin listing from napari hub #313
Conversation
Codecov Report
@@ Coverage Diff @@
## main #313 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 37 37
Lines 2818 2814 -4
=========================================
- Hits 2818 2814 -4
|
Is it deprecated or removed? |
removed. I'll update the description. |
Is it impossible to restore it on few months? To have migration time? |
I created chanzuckerberg/napari-hub#1263 to request this. As far as I can tell [1], no one uses the Since it looks like nothing uses [1]: I did a code search through npe2, napari and npe2api. |
If it is not used, then it should be removed. The napari-plugin-manager should also be checked. |
@aganders3 can you double-check that we're not using the |
I also don't see this used anywhere in napari or the plugin manager. There was a function in the plugin manager using this hub endpoint, but it was not using the npe2 function to reach it anyway. That whole file was removed in napari 0.4.18 and prior to the plugin manager being extracted to its own repo. |
This PR updates for a couple api changes in dependencies that are blocking #311 and #312.
For the napar-hub api, the
/plugins
endpoint was removed (see here). This impacts theget_hub_plugins()
function, and a testtest_get_hub_plugins
which fails without this change. It doesn't appear that anything actually uses these, so this PR removes them.Also build updated to 1.0.
IsolatedEnvBuilder
was renamed toDefaultIsolatedEnv
.