Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error icon and handle pip install errors #79

Closed
Tracked by #14
jaimergp opened this issue Jul 19, 2024 · 1 comment · Fixed by #87
Closed
Tracked by #14

Add error icon and handle pip install errors #79

jaimergp opened this issue Jul 19, 2024 · 1 comment · Fixed by #87
Assignees
Labels
enhancement New feature or request

Comments

@jaimergp
Copy link
Contributor

jaimergp commented Jul 19, 2024

Comes from item in #14. Report refers to this line:

# TODO: add error icon and handle pip install errors

@jaimergp jaimergp mentioned this issue Jul 19, 2024
12 tasks
@jaimergp jaimergp changed the title In the plugin dialog, this was listed: TODO: add error icon and handle pip install errors add error icon and handle pip install errors Jul 19, 2024
@jaimergp jaimergp changed the title add error icon and handle pip install errors Add error icon and handle pip install errors Jul 19, 2024
@jaimergp jaimergp added the enhancement New feature or request label Jul 19, 2024
@goanpeca goanpeca self-assigned this Jul 19, 2024
@jaimergp
Copy link
Contributor Author

I think this is mostly an outdated comment because we do have some feedback methods to notify of errors now, so no need to have extra ones? Probably just needs to be deleted from the code to avoid confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants