Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin dialog requests #14

Closed
11 of 12 tasks
ppwadhwa opened this issue Dec 7, 2022 · 4 comments
Closed
11 of 12 tasks

Plugin dialog requests #14

ppwadhwa opened this issue Dec 7, 2022 · 4 comments
Assignees

Comments

@ppwadhwa
Copy link
Contributor

ppwadhwa commented Dec 7, 2022

🚀 Feature

While working on napari/napari#5198, there were a few requests that were outside of the scope of the PR or were "nice to have" items. I wanted to document them here so they are not lost.

  1. Align plugin name and summary in the installed plugins section.
  2. Use display name instead of package name. See Use display name on plugins that provide it #32
  3. Fix install spinner and move plugins to available/installed list when uninstalled/installed. see: Update plugin dialog design & functionality to add conda install napari#5198 (review)
  4. refactor code, one example is cleaning up the code that toggles which widgets are visible or not:
    Update plugin dialog design & functionality to add conda install napari#5198 (comment)

The following Originally posted by @DragaDoncila in napari/napari#5198 (review)

  • Align installation info, Make a standard size? ( I know this button adjusts by the sizes on the drop down menus held within. Eliding may help here (see item below).

image

  • Ensure author names are aligned. (maybe misaligned only with many authors and in the presence of an update button?)

image

  • Ensure very long descriptions and author lists are not cut off.

image

  • Elide version numbers when long.
    When users have a plugin dev version installed the Installation info button & section is very long. We probably want to elide this

image

  • Set height of each item.
        if item.widget.install_info_button.isExpanded():
            item.widget.setFixedHeight(int(height * SCALE))
        else:
            item.widget.setFixedHeight(int(height / SCALE))
        item.setSizeHint(item.widget.size())

see napari/napari#5198 (comment)

@hiroalchem
Copy link

hiroalchem commented Mar 12, 2023

One request I would like to add.

  • The developer defines the channels (other than conda-forge ) proposed for the plugin, and the GUI allows the user to activate those channels with a single click when they install it.

This is very useful for plugins that rely on very important but released libraries in their own channel, such as pytorch, for example.

@goanpeca goanpeca transferred this issue from napari/napari Jun 28, 2023
@jaimergp
Copy link
Contributor

Let's resume the work here @goanpeca.

@goanpeca
Copy link
Contributor

@hiroalchem question, is your request gear towards the lineedit in the bottom of the dialog where you can type any package or drag and drop a tarball from the filesystem?

Do you mean to add extra channel besides conda-forge, is the case for plugins in the napari plugin ecosystem that they need extra channels besides conda forge?

Thanks!

@jaimergp
Copy link
Contributor

I'll close this issue since most tasks have been addressed. The remaining ones have been converted to issues, namely:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants