Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove legacy support for configuration of transport options on socket #1897

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Oct 21, 2024

Transport specific options should be configured on the end point. This has the most impact for TLS, as TLS dialers and listeners will need to be allocated apriori, to configure TLS options.

Some legacy tests were removed... we're going to remove the legacy libnanomsg compatibility layer anyway.

Transport specific options should be configured on the end point.
This has the most impact for TLS, as TLS dialers and listeners will
need to be allocated apriori, to configure TLS options.

Some legacy tests were removed... we're going to remove the legacy
libnanomsg compatibility layer anyway.
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.09%. Comparing base (d05ff49) to head (53e8dbb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1897      +/-   ##
==========================================
+ Coverage   80.04%   80.09%   +0.05%     
==========================================
  Files          95       95              
  Lines       25011    24974      -37     
  Branches     3395     3380      -15     
==========================================
- Hits        20020    20003      -17     
+ Misses       4918     4897      -21     
- Partials       73       74       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore merged commit 53e8dbb into main Oct 21, 2024
15 of 16 checks passed
@gdamore gdamore deleted the gdamore/drop-socket-set-tranopt branch October 21, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant