Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1313 support deferred nng_aio destruction #1371

Merged
merged 1 commit into from
Dec 13, 2020
Merged

fixes #1313 support deferred nng_aio destruction #1371

merged 1 commit into from
Dec 13, 2020

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Dec 11, 2020

This also converts the HTTP client to make use of this.

@codecov
Copy link

codecov bot commented Dec 12, 2020

Codecov Report

Merging #1371 (2033988) into master (b45f876) will decrease coverage by 0.15%.
The diff coverage is 91.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1371      +/-   ##
==========================================
- Coverage   79.91%   79.76%   -0.16%     
==========================================
  Files          88       88              
  Lines       19346    19389      +43     
==========================================
+ Hits        15460    15465       +5     
- Misses       3886     3924      +38     
Impacted Files Coverage Δ
src/supplemental/http/http_client.c 72.68% <40.00%> (ø)
src/core/aio.c 96.50% <100.00%> (-0.19%) ⬇️
src/nng.c 70.56% <100.00%> (+0.07%) ⬆️
src/supplemental/http/http_conn.c 80.70% <0.00%> (-2.18%) ⬇️
src/protocol/pubsub0/pub.c 94.20% <0.00%> (-1.45%) ⬇️
src/core/listener.c 76.63% <0.00%> (-1.41%) ⬇️
src/transport/ipc/ipc.c 79.85% <0.00%> (-1.29%) ⬇️
src/core/dialer.c 82.49% <0.00%> (-0.78%) ⬇️
src/protocol/survey0/survey.c 93.79% <0.00%> (-0.73%) ⬇️
src/transport/inproc/inproc.c 82.24% <0.00%> (-0.73%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b45f876...2033988. Read the comment docs.

@gdamore gdamore merged commit 2033988 into master Dec 13, 2020
@gdamore gdamore deleted the aiomerge branch December 13, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant