Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix circular import #244

Merged
merged 8 commits into from
Dec 16, 2024
Merged

Conversation

AaronDJohnson
Copy link
Collaborator

This pull request fixes a circular import by moving CompareTimingModels to timing.py and removing import models from model_utils.py.

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 11.94030% with 59 lines in your changes missing coverage. Please review.

Project coverage is 37.29%. Comparing base (d91baf2) to head (03b1ab4).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
enterprise_extensions/timing.py 11.94% 59 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #244   +/-   ##
=======================================
  Coverage   37.29%   37.29%           
=======================================
  Files          20       20           
  Lines        3974     3974           
=======================================
  Hits         1482     1482           
  Misses       2492     2492           
Files with missing lines Coverage Δ
enterprise_extensions/model_utils.py 14.01% <ø> (+0.61%) ⬆️
enterprise_extensions/timing.py 15.90% <11.94%> (-12.67%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6887f81...03b1ab4. Read the comment docs.

@AaronDJohnson AaronDJohnson merged commit cda265d into nanograv:master Dec 16, 2024
10 checks passed
@AaronDJohnson AaronDJohnson deleted the fix_circular_import branch December 16, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants