Fourier series representation of chromatic noise (CMWaveX)

[abhisrkckl]

See #1661.

Like WaveX & DMWaveX

#1797 needs to be merged first. I have merged that PR into this one to implement some validation steps that depend on both CMWaveX and PLChromNoise.

[abhisrkckl]

Here is a comparison between PINT and ENTERPRISE analyses for chromatic noise to ensure the conventions are consistent. This uses a simulated dataset.

This is similar to the simulation studies presented in https://arxiv.org/abs/2405.01977

Harmonic number selection

Parameter estimation

Red point is PINT estimate
Blue lines are injected values
Black corner plot is the ENTERPRISE posterior.

Chromatic noise spectrum

[dlakaplan]

It looks like almost all of the changes to timing_model were general code updates not related to this PR. Is that right? I didn't examine them all in detail, but I'm guessing if all of the tests pass then they are probably OK.

[dlakaplan]

Here is a comparison between PINT and ENTERPRISE analyses for chromatic noise to ensure the conventions are consistent. This uses a simulated dataset.

This is similar to the simulation studies presented in https://arxiv.org/abs/2405.01977

Harmonic number selection

Parameter estimation Red point is PINT estimate Blue lines are injected values Black corner plot is the ENTERPRISE posterior.

Chromatic noise spectrum

This is nice. Since it didn't make it into the paper, and this PR will be hard to find once it is merged, will these results be preserved somehow? Maybe a notebook (but not one that is automatically run unless it is fast)?

[abhisrkckl]

It looks like almost all of the changes to timing_model were general code updates not related to this PR. Is that right? I didn't examine them all in detail, but I'm guessing if all of the tests pass then they are probably OK.

Only the changes to TimingModel.validate_component_types() method are related to this PR. Everything else is refactorings suggested by sourcery.

[dlakaplan]

OK, I think the code looks fine here. Any thoughts on the docs?

[abhisrkckl]

I will add an example notebook as you suggested.

[abhisrkckl]

OK, I think the code looks fine here. Any thoughts on the docs?

Example added to notebook.
https://nanograv-pint--1802.org.readthedocs.build/en/1802/examples/rednoise-fit-example.html#Chromatic-noise-fitting

[dlakaplan]

So is that notebook one that is built & run as part of CI? If so, any estimate of the additional run-time?

[abhisrkckl]

~10 s on my laptop.

[dlakaplan]

OK, good. I can merge when ready then.

[abhisrkckl]

Ok... please do.

…

On Tue, 27 Aug, 2024, 4:37 pm David Kaplan, ***@***.***> wrote: OK, good. I can merge when ready then. — Reply to this email directly, view it on GitHub <#1802 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE6CGN3WGSYWFUIBVDUTWELZTSFLFAVCNFSM6AAAAABKWQLAXKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJSG42TEMJVGM> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>