-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align memory for SDC read on ChibiOS #2889
Align memory for SDC read on ChibiOS #2889
Conversation
de2ac69
to
6e85810
Compare
Fix define for Drive Indexes (should only be a single char). Fixes some comments (spelling).
Automated fixes for code style.
3ba4238
to
e8149e7
Compare
These changes should be addressed in #2911 with the new stream approach and the fixes in ChibiOS community code, therefore OK to close. |
Closing as fixed. |
Warning Rate limit exceeded@nfbot has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 29 minutes and 7 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe changes improve disk I/O functionality, particularly for SD card read operations, by enhancing memory management and state validation. A new aligned buffer is introduced to handle data reads more safely, ensuring proper initialization and cache management. Minor formatting adjustments in function declarations and drive index definitions further improve code readability and consistency without altering logic. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Description
There were sporatic failures with firmware releases on STM32F7 series related to the ability to read the content of files. This is a speculative fix that addresses the immediate issue, although might need applying to MMC and also write functions.
It also addresses:
Motivation and Context
Issues with reading from SD cards.
How Has This Been Tested?
Locally on an ORGPAL_THREE (though had to turn USB MSD
OFF
for the interpreter not to continually crash). Note: build dir must be cleared!Screenshots
Types of changes
Checklist
Summary by CodeRabbit
New Features
Bug Fixes
Documentation