Native code for ESPNOW feature #2218

SandorDobos · 2022-01-06T15:22:38Z

Description

Adds native code supporting nanoFramework.Hardware.Esp32.EspNow managed lib.

Motivation and Context

Resolves ESP32:ESPNOW feature Home#927

How Has This Been Tested?

Used in my own project.

Types of changes

Improvement (non-breaking change that improves a feature, code or algorithm)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Config and build (change in the configuration and build system, has no impact on code or features)
Dependencies (update dependencies and changes associated, has no impact on code or features)
Unit Tests (work on Unit Tests, has no impact on code or features)
Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

…are.Esp32.EspNow

…/github.com/SandorDobos/nf-interpreter into feature-nanoFramework.Hardware.Esp32.EspNow

…eter into feature-nanoFramework.Hardware.Esp32.EspNow

…are.Esp32.EspNow

…/github.com/SandorDobos/nf-interpreter into feature-nanoFramework.Hardware.Esp32.EspNow

…eter into feature-nanoFramework.Hardware.Esp32.EspNow

Automated fixes for code style.

nfbot · 2022-01-06T15:25:45Z

@SandorDobos there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please click SandorDobos#4, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

…eter into feature-nanoFramework.Hardware.Esp32.EspNow

Automated fixes for code style.

…683f' of https://github.com/nanoframework/nf-interpreter into nanoframework-nfbot/clang-format-fix/50006557-6649-4026-8a5a-f6d9c090683f

…-8a5a-f6d9c090683f' into feature-nanoFramework.Hardware.Esp32.EspNow

Automated fixes for code style.

…-8a39-2f742586a29b' into feature-nanoFramework.Hardware.Esp32.EspNow

…-95a3-c13d13bb726b' into feature-nanoFramework.Hardware.Esp32.EspNow

josesimoes · 2022-02-15T21:58:40Z

.devcontainer/devcontainer.json

@@ -16,6 +16,10 @@
 		// Keep command history 
 		"source=nano-bashhistory,target=/home/vscode/commandhistory,type=volume",
 	],
+	"workspaceFolder": "/workspace",


Changes in this file don't belong to this PR, please revert.

josesimoes · 2022-02-15T21:58:53Z

.vscode/cmake-variants-DEVCONTAINER.json

@@ -292,7 +292,8 @@
          "API_nanoFramework.Hardware.Esp32.Rmt": "ON",
    	  "API_System.Device.Dac": "ON",
          "API_nanoFramework.Graphics": "OFF",
-          "API_nanoFramework.Device.Bluetooth": "ON"
+          "API_nanoFramework.Device.Bluetooth": "ON",
+          "API_nanoFramework.Espnow": "ON"


Suggested change

"API_nanoFramework.Espnow": "ON"

"API_nanoFramework.EspNow": "ON"

josesimoes · 2022-02-15T21:59:02Z

.vscode/cmake-variants-DEVCONTAINER.json

@@ -339,7 +340,8 @@
          "API_nanoFramework.Hardware.Esp32.Rmt": "ON",
          "API_System.Device.Dac": "ON",
          "API_nanoFramework.Graphics": "OFF",
-          "API_nanoFramework.Device.Bluetooth": "OFF"
+          "API_nanoFramework.Device.Bluetooth": "OFF",
+          "API_nanoFramework.Espnow": "ON"


Suggested change

"API_nanoFramework.Espnow": "ON"

"API_nanoFramework.EspNow": "ON"

josesimoes · 2022-02-15T21:59:09Z

.vscode/cmake-variants-DEVCONTAINER.json

@@ -387,7 +389,8 @@
          "API_nanoFramework.Hardware.Esp32.Rmt": "ON",
          "API_System.Device.Dac": "ON",
          "API_nanoFramework.Graphics": "OFF",
-          "API_nanoFramework.Device.Bluetooth": "ON"
+          "API_nanoFramework.Device.Bluetooth": "ON",
+          "API_nanoFramework.Espnow": "ON"


Suggested change

"API_nanoFramework.Espnow": "ON"

"API_nanoFramework.EspNow": "ON"

josesimoes · 2022-02-15T21:59:17Z

.vscode/cmake-variants-DEVCONTAINER.json

@@ -483,7 +487,7 @@
          "API_nanoFramework.Hardware.Esp32.Rmt": "ON",
          "API_nanoFramework.Device.Bluetooth": "OFF",
          "API_nanoFramework.Graphics": "ON",
-          "API_Windows.Devices.Adc": "ON",
+          "API_nanoFramework.Espnow": "ON",


Suggested change

"API_nanoFramework.Espnow": "ON",

"API_nanoFramework.EspNow": "ON",

josesimoes · 2022-02-15T22:03:36Z

targets/ESP32/_nanoCLR/nanoFramework.Espnow/nanoFramework_espnow_native.h

@@ -0,0 +1,148 @@
+//-----------------------------------------------------------------------------


Replace with license header.

josesimoes · 2022-02-15T22:04:34Z

...R/nanoFramework.Espnow/nanoFramework_espnow_native_nanoFramework_Espnow_EspNowController.cpp

@@ -0,0 +1,181 @@
+//-----------------------------------------------------------------------------


Replace with license header.

josesimoes · 2022-02-15T22:04:57Z

...R/nanoFramework.Espnow/nanoFramework_espnow_native_nanoFramework_Espnow_EspNowController.cpp

+    ret = esp_now_init();
+    if (ret == ESP_OK)
+    {
+


Suggested change

josesimoes · 2022-02-15T22:05:07Z

...R/nanoFramework.Espnow/nanoFramework_espnow_native_nanoFramework_Espnow_EspNowController.cpp

+        ret = esp_now_register_recv_cb(DataRecvCb);
+        if (ret == ESP_OK)
+        {
+


Suggested change

josesimoes · 2022-02-15T22:05:37Z

...ow/nanoFramework_espnow_native_nanoFramework_Espnow_EspNowController__EspNowEventHandler.cpp

@@ -0,0 +1,160 @@
+//-----------------------------------------------------------------------------


Replace with license header.

josesimoes · 2022-02-15T22:07:07Z

@SandorDobos also waiting for the PR for the manage library.

ricavir11 · 2022-07-19T08:40:22Z

I would like to use ESPNOW with nanoframework.
Would be great to have an ETA for this feature !

josesimoes · 2022-08-19T07:32:46Z

@SandorDobos any chance we can have this PR moved forward? 😅

Ellerbach · 2023-04-18T14:32:43Z

@SandorDobos any help needed to move forward this PR?

Tollervey · 2023-12-25T22:14:30Z

Merry Christmas everyone.... Having this in the framework would be very handy indeed.... Cheers

AdrianSoundy · 2024-05-16T04:54:22Z

@SandorDobos
Any chance of completing this PR or giving ok for someone else to complete

Baker68 · 2024-10-13T20:49:43Z

Man I really hope you merge this.

nfbot · 2024-10-15T23:40:43Z

@SandorDobos there are issues with the code style on the source files.

⚠️Couldn't submit a PR with the fixes against your repo.⚠️

Please merge the changes from https://github.com/nanoframework/nf-interpreter/tree/nfbot/clang-format-fix/8dcdd254-faee-40b8-8213-d670c5a4f546.

SandorDobos and others added 25 commits December 26, 2021 16:43

nanoFramework.Hardware.Esp32.EspNow skeleton added

f825c67

Part impl

e64a009

Try delegates

158b388

Use native events

ba2a3ea

Fix comp errors

4facdea

Connector refresh

f9924e2

Actualized connector

1e217a2

Debug info added

a86a438

debug cleanup

3a21efa

Updated connector

27ee936

Updated connector

91f74eb

cosmetic

8a2337c

more debug log space

8984090

wifi init

544e356

Merge branch 'nanoframework:develop' into feature-nanoFramework.Hardw…

7f302e0

…are.Esp32.EspNow

Merge branch 'feature-nanoFramework.Hardware.Esp32.EspNow' of https:/…

6dfc20a

…/github.com/SandorDobos/nf-interpreter into feature-nanoFramework.Hardware.Esp32.EspNow

Merge branch 'develop' of https://github.com/nanoframework/nf-interpr…

05469e5

…eter into feature-nanoFramework.Hardware.Esp32.EspNow

init trials

20fa635

fix init seq

493a142

Event internals shouldnt be nested classes

4405474

Turn debug messages off

926e96e

Merge branch 'nanoframework:develop' into feature-nanoFramework.Hardw…

9adbb9b

…are.Esp32.EspNow

Merge branch 'feature-nanoFramework.Hardware.Esp32.EspNow' of https:/…

2ac5ff2

…/github.com/SandorDobos/nf-interpreter into feature-nanoFramework.Hardware.Esp32.EspNow

Unnecessary wifi initialization steps removed.

f8aa531

Merge branch 'develop' of https://github.com/nanoframework/nf-interpr…

5844619

…eter into feature-nanoFramework.Hardware.Esp32.EspNow

nfbot changed the title ~~Native code for ESPNOW feature.~~ Native code for ESPNOW feature Jan 6, 2022

nfbot added the Type: enhancement label Jan 6, 2022

Code style fixes

3b287c9

Automated fixes for code style.

josesimoes added the ⚠️ DO NOT MERGE ⚠️ label Jan 6, 2022

SandorDobos and others added 9 commits January 17, 2022 11:29

Merge branch 'develop' of https://github.com/nanoframework/nf-interpr…

908fe63

…eter into feature-nanoFramework.Hardware.Esp32.EspNow

Code style fixes

b317504

Automated fixes for code style.

Merge branch 'nfbot/clang-format-fix/50006557-6649-4026-8a5a-f6d9c090…

9ad1360

…683f' of https://github.com/nanoframework/nf-interpreter into nanoframework-nfbot/clang-format-fix/50006557-6649-4026-8a5a-f6d9c090683f

Merge branch 'nanoframework-nfbot/clang-format-fix/50006557-6649-4026…

e49de06

…-8a5a-f6d9c090683f' into feature-nanoFramework.Hardware.Esp32.EspNow

Code style fixes

a38271e

Automated fixes for code style.

git push origin feature-nanoFramework.Hardware.Esp32.EspNow

859c329

Merge branch 'nanoframework-nfbot/clang-format-fix/7a3c4f4e-a77a-49cd…

543da36

…-8a39-2f742586a29b' into feature-nanoFramework.Hardware.Esp32.EspNow

merge nfbot

2743ce2

Merge branch 'nanoframework-nfbot/clang-format-fix/1a6a425f-9de3-4f60…

dd68109

…-95a3-c13d13bb726b' into feature-nanoFramework.Hardware.Esp32.EspNow

josesimoes force-pushed the develop branch 10 times, most recently from 02961e4 to ff3b7cd Compare February 9, 2022 15:06

Merge branch 'develop' into feature-nanoFramework.Hardware.Esp32.EspNow

d159e0f

josesimoes requested changes Feb 15, 2022

View reviewed changes

Merge branch 'develop' into feature-nanoFramework.Hardware.Esp32.EspNow

5189ea3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Native code for ESPNOW feature #2218

Native code for ESPNOW feature #2218

SandorDobos commented Jan 6, 2022

nfbot commented Jan 6, 2022

josesimoes Feb 15, 2022

josesimoes Feb 15, 2022

josesimoes Feb 15, 2022

josesimoes Feb 15, 2022

josesimoes Feb 15, 2022

josesimoes Feb 15, 2022

josesimoes Feb 15, 2022

josesimoes Feb 15, 2022

josesimoes Feb 15, 2022

josesimoes Feb 15, 2022

josesimoes commented Feb 15, 2022

ricavir11 commented Jul 19, 2022

josesimoes commented Aug 19, 2022

Ellerbach commented Apr 18, 2023

Tollervey commented Dec 25, 2023

AdrianSoundy commented May 16, 2024

Baker68 commented Oct 13, 2024

nfbot commented Oct 15, 2024

	"API_nanoFramework.Espnow": "ON"
	"API_nanoFramework.EspNow": "ON"

	"API_nanoFramework.Espnow": "ON",
	"API_nanoFramework.EspNow": "ON",

		@@ -0,0 +1,148 @@
		//-----------------------------------------------------------------------------

		@@ -0,0 +1,181 @@
		//-----------------------------------------------------------------------------

		@@ -0,0 +1,160 @@
		//-----------------------------------------------------------------------------

Native code for ESPNOW feature #2218

Are you sure you want to change the base?

Native code for ESPNOW feature #2218

Conversation

SandorDobos commented Jan 6, 2022

Description

Motivation and Context

How Has This Been Tested?

Types of changes

Checklist:

nfbot commented Jan 6, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

josesimoes commented Feb 15, 2022

ricavir11 commented Jul 19, 2022

josesimoes commented Aug 19, 2022

Ellerbach commented Apr 18, 2023

Tollervey commented Dec 25, 2023

AdrianSoundy commented May 16, 2024

Baker68 commented Oct 13, 2024

nfbot commented Oct 15, 2024