Remove legacy bootstrap #4777
Merged
Remove legacy bootstrap #4777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results for Commit 93385bbPull Request 4777: Results Test Case Results
Last updated: 2024-10-31 13:38:00 UTC |
pwojcikdev
force-pushed
the
remove-legacy-bootstrap-2
branch
4 times, most recently
from
a9b2d97
to
4071670
Compare
pwojcikdev
force-pushed
the
remove-legacy-bootstrap-2
branch
from
4071670
to
c88b196
Compare
|
I rebased it on top of frontier scan PR #4739 as without the frontier sca spam test suite had trouble keeping all frontiers in sync. |
pwojcikdev
force-pushed
the
remove-legacy-bootstrap-2
branch
from
c88b196
to
cc3299f
Compare
pwojcikdev
force-pushed
the
remove-legacy-bootstrap-2
branch
from
cc3299f
to
ff8b6a1
Compare
clemahieu
previously approved these changes
Oct 31, 2024
pwojcikdev
dismissed
clemahieu’s stale review
The merge-base changed after approval.
# Conflicts: # nano/node/bootstrap/account_sets.hpp # nano/node/bootstrap/bootstrap.cpp # nano/node/bootstrap/bootstrap.hpp # nano/node/bootstrap/bootstrap_attempt.hpp # nano/node/bootstrap/bootstrap_bulk_push.cpp # nano/node/bootstrap/bootstrap_bulk_push.hpp # nano/node/bootstrap/bootstrap_connections.cpp # nano/node/bootstrap/bootstrap_connections.hpp # nano/node/bootstrap/bootstrap_lazy.cpp # nano/node/json_handler.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes legacy bootstrap, which was replaced by the new ascending bootstrap. Legacy bootstrap implementation was unnecessarily complicated with many inefficiencies. Debugging it was a pain and slowed down development of new features.
All the
bootstrap_ascending*classes and stats are renamed to simplybootstrap.TODO for the future is porting previous
bootstrap_processortest suite to use the new bootstrapper.