Remove election_winner_details container
#4755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwojcikdev
force-pushed
the
remove-election-winner-details
branch
from
192734a
to
b9f0225
Compare
clemahieu
previously approved these changes
Oct 16, 2024
Test Results for Commit 6883c4dPull Request 4755: Results Test Case Results
Last updated: 2024-10-18 02:56:49 UTC |
# Conflicts: # nano/node/node.hpp
pwojcikdev
force-pushed
the
remove-election-winner-details
branch
from
4847439
to
6883c4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
election_winner_detailscontainer which proved to be difficult to keep in sync and was leaking entires when rollbacks were performed (as part of bounded backlog work). The election that triggered the cementing is now passed as part of context, ie. the flow of cementing is:election::confirm_once (...) > confirming_set::add (...) > confirming_set::batch_cemented event > active_elections::block_cemented callback (...)where election is passed through the pipeline.