Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve nano::test::system::add_node (...) #4731

Merged

Conversation

pwojcikdev
Copy link
Contributor

I encountered a problem where nano::test::system::add_node (...) wouldn't properly connect all nodes. I simplified the code, removing legacy bootstrap waits, and it seems to work fine. Additionally I extended the initialization blocks list to

void set_initialization_blocks (std::deque<std::shared_ptr<nano::block>> blocks);
void set_cemented_initialization_blocks (std::deque<std::shared_ptr<nano::block>> blocks);

in order to simplify setting up multiple nodes with the same set of blocks.

@pwojcikdev pwojcikdev merged commit 5c306a0 into nanocurrency:develop Sep 21, 2024
26 of 28 checks passed
@pwojcikdev pwojcikdev deleted the system-connect-node-fixes branch September 21, 2024 07:53
@qwahzi qwahzi added this to the V28 milestone Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged / V28.0
Development

Successfully merging this pull request may close these issues.

3 participants