Fix correctness, sanity check, and resolve shutdown issue. #4719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er information without acquiring the entries_mutex.
pwojcikdev
reviewed
Sep 3, 2024
clemahieu
force-pushed
the
tsan_fixes
branch
4 times, most recently
from
756ff3a
to
13c6a74
Compare
Fixes checking whether the component is stopped.
…ch is used by std::views::take. This issue was flagged by VisualStudio debug asserts
clemahieu
force-pushed
the
tsan_fixes
branch
from
13c6a74
to
aae52f6
Compare
pwojcikdev
approved these changes
Sep 4, 2024
clemahieu
added a commit
that referenced
this pull request
Sep 6, 2024
Fix correctness, sanity check, and resolve shutdown issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a missing mutex lock entries_mutex in unchecked_map::collect_container_info.
Sanity check the equality of the iterator qualified root to the item searched for.
Consider stopped flag when wait-looping. Use condition_variable::wait rather than this_thread::sleep_for