Add database information to telemetry data #4675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added a testcase that ensures proper telemetry serialization, which currently fails. It's a bit concerning that existing tests don't ensure that telemetry is correctly transmitted between nodes. I also noticed that we're missing testcases for serialization of |
pwojcikdev
force-pushed
the
Telemetry-db-backend
branch
2 times, most recently
from
e6176f0
to
f0f46a0
Compare
pwojcikdev
force-pushed
the
Telemetry-db-backend
branch
from
f0f46a0
to
4a7ac42
Compare
Include backend
pwojcikdev
force-pushed
the
Telemetry-db-backend
branch
from
75f60da
to
8c14932
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds telemetry information about the type of database backend the node is using.
The telemetry RPC function reports both individual database backend information or consolidated (average). The reported database backend for each node will be either 'RocksDb' , 'LMDB' or "Unknown".
'Unknown' is for nodes running v26.1 or earlier that does not send any database information in telemetry data.