Add ability for channels to pause/resume processing of incoming messages #4612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a message is received from the network and placed in to the fair_queue, the queue is checked to see if the message queue is full for this channel. If full, the channel is placed in a paused state where new messages are not received. When the message_processor processes items for a channel, it signals the associated channel to resume if it was in a paused state.
|
I don't think it works right now, I added a new core test to ensure proper behavior. Throttling is a bit tricky with the current networking architecture. Depending on how critical it is to get it working right now, this will probably be much easier to implement with networking code implemented using coroutines, using primitives like asynchronous conditions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow on to PR #4609 and responds to the fair queue for a channel being full by pausing incoming message processing for the channel.
Pausing incoming message handling will cause TCP flow control to back up to the sender and limit incoming data.