Redesign the priority scheduler to maintain a 1-to-1 link with running elections #4593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemahieu
force-pushed
the
priority_limiter
branch
3 times, most recently
from
aad626f
to
456acf9
Compare
clemahieu
force-pushed
the
priority_limiter
branch
3 times, most recently
from
0f7d29c
to
733ec4f
Compare
clemahieu
force-pushed
the
priority_limiter
branch
4 times, most recently
from
ecdbcdd
to
a3ea5fa
Compare
clemahieu
force-pushed
the
priority_limiter
branch
from
d4a7886
to
4feb0be
Compare
Each scheduler checks its own limits with calls to active_elections::vacancy. Trim is problematic as it indiscriminately cancels elections without consideration to why it was scheduled or its priority.
…en rather than using vacancy() Remove election_scheduler.no_vacancy
Schedulers only get notifications when an election is closed i.e. vacancy has increased.
Convert vacancy_update to election_stopped observer. Reworking buckets. Fixing bucket WIP WIP Commenting removal selection Scheduler logging. Increase timestamp precision. Formatting. Removing completed elections.
clemahieu
force-pushed
the
priority_limiter
branch
from
4feb0be
to
d4f8807
Compare
|
Removing from V27 milestone due to: #4626 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change appropriately prioritises elections by bucket and then by LRU account. Overfilled buckets have the lowest priority block election cancelled and rolled back.