Use c++ std filesystem #4309
Closed
Use c++ std filesystem #4309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemahieu
requested changes
Oct 18, 2023
There was a problem hiding this comment.
I changed how file opening errors are handled in #4314 which means we won't need to remove the associated test here.
I tried to push a commit on top of this branch but it looks like GitHub branch protection rules prevent this.
Please rebase and this should be good to go.
RickiNano
force-pushed
the
use-c++-std-filesystem
branch
from
86e311a
to
efc1dd5
Compare
|
Github runners are reporting some strange linker errors after rebasing this PR on current develop branch. |
|
The linker errors were related to GitHub caching. I cleared the cache and re-ran and they passed so I committed the other PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces all uses of boost filesystem with standard c++ filesystem.
A couple of notes:
boost::filesystem::unique_path is not supported in std::filesystem. I have re-written the nano::unique_path function found in /secure/utility.cpp so that it mimics the same behavior.
The "bad_path" unit test fails in LMDB mode when the path input is set to "///" because of the way std::filesystem handles invalid paths. I have removed this test.
Target issue: #4057