Replace boost filesystem with std filesystem #4308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I got both issues fixed now. I'll close this draft PR and I will reopen a "real" pr when everything is ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces boost filesystem with the c++17 std filesystem
It builds and runs on my pc but it does have at least two issues that I hope someone more knowledgeable can either fix or tell me how to fix:
2. In secure/utility.cpp we used boost::filesystem::unique_path () but this is not available in std filesystem. I have changed the unique_path function to always return "temp" as a workaround for nowEDIT: The second issue has been resolved with a custom function but I need help with the first one
This PR targets: #4057