Add utility to get values for maps and multi_index containers #4303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a generic `get_value` function to streamline the process of retrieving values from maps. - Refactored `active_transactions.cpp` to use the new helper, improving code readability. # This function simplifies map value retrieval by encapsulating the find-check-return pattern.
- Introduced `get_value_multi_index` in the utility class to facilitate value retrieval from Boost multi-index containers. - Refactored `active_transactions.cpp` to utilise the new utility function, streamlining code readability. This change aids in centralising the logic for multi-index value retrieval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I personally have a hard time know if
if (existing == roots.get<tag_root> ().end ())means existing is true or false.
I added an utility
get_valueandget_value_multi_indexto make it more obviousif (!existing_entry)I made the changes for one active_transactions class to seee what it would look like and marked the PR as draft.