Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove separate signature checking thread classes #4267

Merged
merged 5 commits into from
Nov 6, 2023
Merged

Remove separate signature checking thread classes #4267

merged 5 commits into from
Nov 6, 2023

Commits on Nov 6, 2023

  1. Add explicit negative-test for state block and epoch block signature … 

    …checking
    @clemahieu
    clemahieu committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    51d6aa4 View commit details
    Browse the repository at this point in the history

  2. Enqueue all blocks from block_processor::add_impl in to block_process… 

    …or::blocks regardless of type.

Negative testing for signatures of state/epoch blocks is done with ledger.fail_state_bad_signature and ledger.fail_epoch_bad_signature. Signature checking is always done within the block verification functions themselves since nanocurrency#4021
    @clemahieu
    clemahieu committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    dd7a4e1 View commit details
    Browse the repository at this point in the history

  3. Remove usage of signature_check_set from nano::vote_processor

    @clemahieu
    clemahieu committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    dd121a8 View commit details
    Browse the repository at this point in the history

  4. Remove unused signature checking classes

    @clemahieu
    clemahieu committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    dc536b9 View commit details
    Browse the repository at this point in the history

  5. Fix race condition identified by TSAN when computing hash

    @clemahieu
    clemahieu committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    906cbbf View commit details
    Browse the repository at this point in the history