Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Docker build type #4249

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Fix Docker build type #4249

merged 1 commit into from
Jun 22, 2023

Conversation

pwojcikdev
Copy link
Contributor

I forgot to declare a BUILD_TYPE environment variable inside the Dockerfile in a recent PR. It meant that Docker builds would always happen in Debug mode. This PR changes that to RelWithDebInfo by default with a possibility of overriding it by passing the variable manually.

@pwojcikdev pwojcikdev merged commit 54593ee into nanocurrency:develop Jun 22, 2023
15 of 17 checks passed
@pwojcikdev pwojcikdev deleted the fix-docker-build-type branch June 22, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clemahieu clemahieu clemahieu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pwojcikdev @clemahieu