Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

962 use mid level render apis for render #964

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bevy_nannou/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ fn update_mesh(mut handles: Query<(&Handle<Mesh>, &mut Transform)>) {
}

fn update_draw(
draw: Query<(&mut bevy_nannou_draw::Draw)>,
draw: Query<&mut bevy_nannou_draw::Draw>,
texture_handle: Res<MyTexture>,
images: Res<Assets<Image>>,
time: Res<Time>,
Expand Down
4 changes: 2 additions & 2 deletions bevy_nannou_draw/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ impl Plugin for NannouDrawPlugin {
}
}

fn spawn_draw(mut commands: Commands, query: Query<(Entity, &Camera), Added<Camera>>) {
for (entity, _camera) in query.iter() {
fn spawn_draw(mut commands: Commands, query: Query<Entity, Added<Camera>>) {
for entity in query.iter() {
commands.entity(entity).insert(Draw(draw::Draw::new()));
}
}
Expand Down
147 changes: 147 additions & 0 deletions bevy_nannou_render/src/draw_function.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,147 @@
use bevy::ecs::query::ROQueryItem;
use bevy::ecs::system::lifetimeless::{Read, SRes};
use bevy::ecs::system::SystemParamItem;
use bevy::pbr::SetMeshViewBindGroup;
use bevy::render::extract_component::DynamicUniformIndex;
use bevy::render::render_asset::RenderAssets;
use bevy::render::render_phase::{
PhaseItem, RenderCommand, RenderCommandResult, SetItemPipeline, TrackedRenderPass,
};
use bevy::render::render_resource as wgpu;

use crate::pipeline::NannouPipeline;
use crate::{
DefaultTextureHandle, DrawMesh, DrawMeshHandle, DrawMeshItem, DrawMeshUniform,
DrawMeshUniformBindGroup, TextureBindGroupCache,
};

pub type DrawDrawMeshItem3d = (
SetItemPipeline,
SetMeshViewBindGroup<0>,
SetDrawMeshUniformBindGroup<1>,
SetDrawMeshTextBindGroup<2>,
SetDrawMeshTextureBindGroup<3>,
SetDrawMeshScissor,
DrawDrawMeshItem,
);

pub struct SetDrawMeshUniformBindGroup<const I: usize>;
impl<const I: usize, P: PhaseItem> RenderCommand<P> for SetDrawMeshUniformBindGroup<I> {
type Param = SRes<DrawMeshUniformBindGroup>;
type ViewWorldQuery = ();
type ItemWorldQuery = Read<DynamicUniformIndex<DrawMeshUniform>>;

#[inline]
fn render<'w>(
_item: &P,
_view: ROQueryItem<'w, Self::ViewWorldQuery>,
uniform_index: ROQueryItem<'w, Self::ItemWorldQuery>,
bind_group: SystemParamItem<'w, '_, Self::Param>,
pass: &mut TrackedRenderPass<'w>,
) -> RenderCommandResult {
pass.set_bind_group(
I,
&bind_group.into_inner().bind_group,
&[uniform_index.index()],
);
RenderCommandResult::Success
}
}

pub struct SetDrawMeshTextureBindGroup<const I: usize>;
impl<const I: usize, P: PhaseItem> RenderCommand<P> for SetDrawMeshTextureBindGroup<I> {
type Param = (SRes<DefaultTextureHandle>, SRes<TextureBindGroupCache>);
type ViewWorldQuery = ();
type ItemWorldQuery = Read<DrawMeshItem>;

#[inline]
fn render<'w>(
_item: &P,
_view: ROQueryItem<'w, Self::ViewWorldQuery>,
draw_mesh_item: ROQueryItem<'w, Self::ItemWorldQuery>,
(default_texture, bind_groups): SystemParamItem<'w, '_, Self::Param>,
pass: &mut TrackedRenderPass<'w>,
) -> RenderCommandResult {
let texture = match &draw_mesh_item.texture {
None => &default_texture.0,
Some(texture) => texture,
};

let Some(bind_group) = bind_groups.into_inner().get(texture) else {
return RenderCommandResult::Failure;
};

pass.set_bind_group(I, &bind_group, &[]);
RenderCommandResult::Success
}
}

pub struct SetDrawMeshTextBindGroup<const I: usize>;
impl<const I: usize, P: PhaseItem> RenderCommand<P> for SetDrawMeshTextBindGroup<I> {
type Param = SRes<NannouPipeline>;
type ViewWorldQuery = ();
type ItemWorldQuery = ();

#[inline]
fn render<'w>(
_item: &P,
_view: ROQueryItem<'w, Self::ViewWorldQuery>,
_entity: ROQueryItem<'w, Self::ItemWorldQuery>,
pipeline: SystemParamItem<'w, '_, Self::Param>,
pass: &mut TrackedRenderPass<'w>,
) -> RenderCommandResult {
pass.set_bind_group(I, &pipeline.into_inner().text_bind_group, &[]);
RenderCommandResult::Success
}
}

pub struct SetDrawMeshScissor;
impl<P: PhaseItem> RenderCommand<P> for SetDrawMeshScissor {
type Param = ();
type ViewWorldQuery = ();
type ItemWorldQuery = Read<DrawMeshItem>;

fn render<'w>(
_item: &P,
_view: ROQueryItem<'w, Self::ViewWorldQuery>,
entity: ROQueryItem<'w, Self::ItemWorldQuery>,
_param: SystemParamItem<'w, '_, Self::Param>,
pass: &mut TrackedRenderPass<'w>,
) -> RenderCommandResult {
if let Some(scissor) = entity.scissor {
pass.set_scissor_rect(scissor.left, scissor.bottom, scissor.width, scissor.height);
}

RenderCommandResult::Success
}
}

pub struct DrawDrawMeshItem;
impl<P: PhaseItem> RenderCommand<P> for DrawDrawMeshItem {
type Param = SRes<RenderAssets<DrawMesh>>;
type ViewWorldQuery = Read<DrawMeshHandle>;
type ItemWorldQuery = Read<DrawMeshItem>;

#[inline]
fn render<'w>(
_item: &P,
handle: ROQueryItem<'w, Self::ViewWorldQuery>,
draw_mesh_item: ROQueryItem<'w, Self::ItemWorldQuery>,
draw_meshes: SystemParamItem<'w, '_, Self::Param>,
pass: &mut TrackedRenderPass<'w>,
) -> RenderCommandResult {
let Some(mesh) = draw_meshes.into_inner().get(&handle.0) else {
return RenderCommandResult::Failure;
};

// Set the buffers.
// Note: this is a no-op if the buffers have already been set on this pass
pass.set_index_buffer(mesh.index_buffer.slice(..), 0, wgpu::IndexFormat::Uint32);
pass.set_vertex_buffer(0, mesh.point_buffer.slice(..));
pass.set_vertex_buffer(1, mesh.color_buffer.slice(..));
pass.set_vertex_buffer(2, mesh.tex_coords_buffer.slice(..));

pass.draw_indexed(draw_mesh_item.index_range.clone(), 0, 0..1);
RenderCommandResult::Success
}
}
Loading
Loading