Update to winit 0.27. Handle new window events (IME and Occluded) #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit updates nannou and nannou_egui to use winit to 0.27+. The window attribute of the WindowBuilder is now private, we use the WindowBuilder methods to properly build the window in window.rs. Because the properties of the `Window` currently being built cannot be accessed from the `WindowBuilder` anymore, some additional properties have to be stored in the `Builder` struct which are mirrors of the `Window`'s properties. These properties allow checking if a value and what it was set to. `Builder` now has `fullscreen` `size`, `min_size`, and `max_size` as new properties. The `set_cursor_grab` has also been updated with the new winit enum `CursorGrabMode`. If the cursor should be grabbed, we first try to confine it, then try to lock it (see https://docs.rs/winit/latest/winit/window/enum.CursorGrabMode.html).
The Ime event corresponds to a "composition event". It will never be sent if `Window::set_ime_allowed` is not called. These events are stateful, they first need to be enabled and successive events need to be combined. This should be a separate feature since it will require some extra work to handle. The occluded event is handled a function can be used to take advantage of it. For example, costly rendering can be avoided if the window is occluded (hidden from view).
|
Hey thanks so much for the PR @hugcis! I actually began addressing this update over the weekend as a part of an update to wgpu 0.14 and egui 0.20 😅 you can find my WIP branch here. I plan to resume work on this over the coming weekend, though we're encountering some issues with the way |
|
Hey @mitchmindtree, No problem, I am happy to help with nannou! I see you are using an unmerged PR of winit (rust-windowing/winit#2613), which allows skipping some of the workarounds I had to make to update to 0.27. It probably makes more sense to update winit with wgpu and egui in one go. |
|
Any plans to revisit this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This pull request addresses issue #903 and updates the nannou and nannou_egui libraries to be compatible with winit version 0.27+.
One breaking change in winit 0.27 is the removal of the
WindowAttributesfield onWindowBuilder.As a result, additional fields were added tonannou::window::Builderto track properties such asinner_sizeandmin_inner_sizebefore building the window.The winit update also introduces two new events: IME and Occluded.
Window::set_ime_allowedis called. I ignored the event because the added complexity would outweigh the benefits, but I may be wrong.boolwhich I believe indicates if the window is hidden or not (this is not documented in winit). This event can be useful to save computations when the window is not visible.Summary of changes: