Add black to requirements and pre-commit #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caneff
force-pushed
the
black
branch
2 times, most recently
from
d450db9 to
0441e49
Compare
caneff
force-pushed
the
black
branch
3 times, most recently
from
1e75d2f to
773a73c
Compare
|
OK I think I addressed all your points from the other PR. Sorry it was easier for me to just close that one and continue here. |
caneff
force-pushed
the
black
branch
4 times, most recently
from
72c635f to
6597b2c
Compare
|
OK fixed the remaining issues |
nanne-aben
reviewed
Oct 19, 2023
There was a problem hiding this comment.
Sorry to be nitpicking, but I feel like the code in the notebooks is sometimes formatted a bit funky. I've made some suggestions to add a , in some places. If I'm not mistaken, black will use these to reformat these pieces of codes with some newlines, making them more readable. I've also made suggestions to remove some redundant ().
|
OK think I did them all. |
caneff
force-pushed
the
black
branch
3 times, most recently
from
ab9f2e0 to
2a8426c
Compare
Follow on PR to reformat existing files
nanne-aben
approved these changes
Oct 20, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.