Update queue flags to be optional #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixing an issue with serialisation to JSON. Will push a fix soon. |
@JKRhb This has now been fixed and tested. |
JKRhb
reviewed
Jul 7, 2023
There was a problem hiding this comment.
Thank you for your PR, @noelatmerqury :) The changes look good to me, we'll be able to merge as soon as @jwhb has given his approval :)
|
Nice contribution, thanks @noelatmerqury! |
jwhb
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the
Queueflags to be optional because they may not always be provided. For example running the below commands would result in an outputJSONthat would cause the library to return an error when parsing.sudo nft add table ip mytable sudo nft add chain ip mytable out-chain "{ type filter hook output priority 0;}" sudo nft add rule ip mytable out-chain udp dport 20000 queue num 0This
PRfixes this issue by setting the queue flags as optional. An associated unit test has been added to verify functionality.