libcoap/src/crypto/psk/client.rs|71 col 37| warning: use of .then_some(..).unwrap_or(..) can be written more clearly with if .. else ..
--> libcoap/src/crypto/psk/client.rs:71:37
|
71 | self.ctx.raw_cfg.ec_jpake = ec_jpake.then_some(1).unwrap_or(0);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: if ec_jpake { 1 } else { 0 }
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#obfuscated_if_else
= note: #[warn(clippy::obfuscated_if_else)] on by default
libcoap/src/crypto/psk/client.rs|77 col 36| warning: use of .then_some(..).unwrap_or(..) can be written more clearly with if .. else ..
--> libcoap/src/crypto/psk/client.rs:77:36
|
77 | self.ctx.raw_cfg.use_cid = use_cid.then_some(1).unwrap_or(0);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: if use_cid { 1 } else { 0 }
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#obfuscated_if_else
libcoap/src/crypto/psk/client.rs|231 col 39| warning: derefed type is same as origin
--> libcoap/src/crypto/psk/client.rs:231:39
|
231 | if identity_hint.is_none() || key.identity().as_deref() == identity_hint {
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: key.identity()
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref
= note: #[warn(clippy::needless_option_as_deref)] on by default
libcoap/src/crypto/psk/key.rs|127 col 43| warning: casting the result of from_raw_parts_mut to *mut [u8]
--> libcoap/src/crypto/psk/key.rs:127:43
|
127 | let data = unsafe { Box::from_raw(std::slice::from_raw_parts_mut(key.s as *mut u8, key.length) as *mut [u8]) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: core::ptr::slice_from_raw_parts_mut(key.s as *mut u8, key.length)
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_slice_from_raw_parts
= note: #[warn(clippy::cast_slice_from_raw_parts)] on by default
libcoap/src/crypto/psk/key.rs|136 col 19| warning: useless conversion to the same type: std::boxed::Box<[u8]>
--> libcoap/src/crypto/psk/key.rs:136:19
|
136 | data: value.into(),
| ^^^^^^^^^^^^ help: consider removing .into(): value
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
libcoap/src/crypto/psk/server.rs|75 col 37| warning: use of .then_some(..).unwrap_or(..) can be written more clearly with if .. else ..
--> libcoap/src/crypto/psk/server.rs:75:37
|
75 | self.ctx.raw_cfg.ec_jpake = ec_jpake.then_some(1).unwrap_or(0);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: if ec_jpake { 1 } else { 0 }
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#obfuscated_if_else
libcoap/src/crypto/psk/server.rs|236 col 23| warning: derefed type is same as origin
--> libcoap/src/crypto/psk/server.rs:236:23
|
236 | .find(|k| k.identity().as_deref().is_some_and(|kid| kid == identity))
| ^^^^^^^^^^^^^^^^^^^^^^^ help: try: k.identity()
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref
libcoap/src/crypto/psk/server.rs|255 col 20| warning: this call to as_ref does nothing
--> libcoap/src/crypto/psk/server.rs:255:20
|
255 | let keys = self.as_ref();
| ^^^^^^^^^^^^^ help: try: self
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
= note: #[warn(clippy::useless_asref)] on by default
libcoap/src/types.rs|761 col 17| warning: using libc::strlen on a CString or CStr value
--> libcoap/src/types.rs:761:17
|
761 | libc::strlen(uri.uri_str.0.as_ptr()),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: uri.uri_str.0.as_bytes().len()
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#strlen_on_c_strings
= note: #[warn(clippy::strlen_on_c_strings)] on by default

libcoap/src/types.rs|379 col 86| warning: can be more succinctly written as a byte str
--> libcoap/src/types.rs:379:86
|
379 | Self::construct_uri_string_from_parts(scheme, host, port, path.unwrap_or(&[b'/']), query.unwrap_or(&[]))?;
| ^^^^^^^ help: try: b"/"
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#byte_char_slices
= note: #[warn(clippy::byte_char_slices)] on by default
libcoap/src/types.rs|419 col 86| warning: can be more succinctly written as a byte str
--> libcoap/src/types.rs:419:86
|
419 | Self::construct_uri_string_from_parts(scheme, host, port, path.unwrap_or(&[b'/']), query.unwrap_or(&[]))?;
| ^^^^^^^ help: try: b"/"
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#byte_char_slices
libcoap/src/resource.rs|104 col 11| warning: methods uri_path and as_any are never used
--> libcoap/src/resource.rs:106:8
|
104 | pub trait UntypedCoapResource: Any + Debug {
| ------------------- methods in this trait
105 | /// Returns the uri_path this resource responds to.
106 | fn uri_path(&self) -> &str;
| ^^^^^^^^
...
113 | fn as_any(&self) -> &dyn Any;
| ^^^^^^
|
= note: #[warn(dead_code)] on by default
libcoap/src/context.rs|100 col 17| warning: useless conversion to the same type: u32
--> libcoap/src/context.rs:100:17
|
100 | / (COAP_BLOCK_USE_LIBCOAP | COAP_BLOCK_SINGLE_BODY)
101 | | .try_into()
| |_______________________________^
|
= help: consider removing .try_into()
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: #[warn(clippy::useless_conversion)] on by default