Fix some nits regarding the CI pipeline

[pulsastrix]

Moved the documentation build to the unprivileged test.yml pipeline, disabled Pages deployments if the CI variable DOCS_AND_COV_REPO is not set.

• Building docs in the unprivileged pipeline improves security (cargo doc executes the build script, which should not happen in the privileged pipeline).
• Only deploying if vars.DOCS_AND_COV_REPO is set prevents errors when running the pipeline on a fork that does not have GitHub Pages enabled.
• Also fixed the commit hash for PR comments.

[github-actions]

Workflow Status Report

Generated for commit 8d14589 on Thu Dec 19 16:08:03 UTC 2024.

In case of failure, clippy warnings and rustfmt changes (if any) will be indicated as CI check warnings in the file comparison view.

Documentation: Read Online Download

Coverage Report: Read Online Download

Note: Online versions of documentation and coverage reports may not be available indefinitely, especially after the pull request was merged.

Code Coverage Report

Coverage target is 80%.

Click on the coverage badge to access the full coverage report including a source code view.

Expand to view coverage statistics

file	coverage	covered	missed_lines
libcoap-sys/src/lib.rs	86.26%	270 / 313	141-152, 193, 198, 208, 258, 263, 320-337, 458-461, 541-544
libcoap/src/context.rs	61.50%	230 / 374	93, 151-196, 203-210, 227, 256, 303-306, 340, 355-357, 422, 427, 443, 451-613
libcoap/src/crypto/pki_rpk/key.rs	56.67%	51 / 90	171-210, 234-242, 244-247, 253-255
libcoap/src/crypto/pki_rpk/mod.rs	21.90%	99 / 452	35-278, 449-481, 502-600, 608, 611, 645-663, 673-675, 680-682, 687-689, 750, 762-898
libcoap/src/crypto/pki_rpk/pki.rs	78.08%	114 / 146	77-136, 289-302
libcoap/src/crypto/pki_rpk/rpk.rs	72.60%	53 / 73	61-91, 153-164
libcoap/src/crypto/psk/client.rs	45.07%	64 / 142	70-74, 82, 103-189, 231-239, 266-268, 273-275, 303-335
libcoap/src/crypto/psk/key.rs	61.46%	59 / 96	42-49, 163-205
libcoap/src/crypto/psk/mod.rs	0.00%	0 / 45	28-98
libcoap/src/crypto/psk/server.rs	30.95%	52 / 168	67-86, 94, 97, 112-115, 141-143, 148-150, 155-157, 185-230, 251, 267-392
libcoap/src/error.rs	0.00%	0 / 6	91-171
libcoap/src/event.rs	29.73%	11 / 37	33-166
libcoap/src/lib.rs	0.00%	0 / 64	99-202
libcoap/src/mem.rs	72.89%	121 / 166	145-160, 193-195, 207-209, 277, 293-295, 316-321, 350-352, 366, 378-390, 451-453, 470, 478-485, 504, 524, 528
libcoap/src/message/mod.rs	58.46%	190 / 325	107-110, 112-133, 141-147, 149-170, 174, 176, 178, 210, 212, 215-224, 227-245, 247-251, 267-277, 297-304, 400, 443, 449, 480, 490-493, 499-501, 508, 513-525, 531, 551-553, 563-565
libcoap/src/message/request.rs	34.12%	101 / 296	52, 69-203, 229-257, 265-366, 372-376, 381-382, 384-387, 390, 396-402, 431-433, 437, 440-442, 445-447, 450, 453, 456, 459, 462, 473-480
libcoap/src/message/response.rs	22.17%	45 / 203	33-157, 162, 165, 168, 171, 174, 192-322, 326-331, 357
libcoap/src/prng.rs	55.41%	41 / 74	67, 79-117, 140-150, 197
libcoap/src/protocol.rs	32.58%	58 / 178	145-147, 152-157, 159-174, 176-177, 184-189, 191-206, 208-209, 229-268, 289, 303-305, 347-352, 361-366, 372-383, 437-464, 470-483, 515, 517
libcoap/src/resource.rs	70.49%	172 / 244	64, 96-98, 173-178, 185-210, 216-221, 251, 268-290, 302-305, 330-333, 366-375, 508-510
libcoap/src/session/client.rs	90.00%	135 / 150	156, 183, 212, 220-222, 228-230, 276-282
libcoap/src/session/mod.rs	39.19%	107 / 273	56-65, 96, 106-221, 231-276, 285-288, 297-308, 337, 341, 373-393, 415, 423, 451, 458, 476-482, 558, 564
libcoap/src/session/server.rs	81.33%	61 / 75	69-71, 75, 143, 153-155, 170, 185-191
libcoap/src/transport.rs	70.97%	22 / 31	28-35, 54
libcoap/src/types.rs	58.49%	341 / 583	76-122, 128-157, 200-213, 231-233, 243-255, 262-268, 274-276, 285, 552, 561, 573, 636, 662-731, 784, 829-850, 871-873, 889-894, 905-990
libcoap/tests/common/dtls.rs	100.00%	39 / 39
libcoap/tests/common/mod.rs	98.75%	79 / 80	104
libcoap/tests/dtls_pki_client_server_test.rs	100.00%	82 / 82
libcoap/tests/dtls_psk_client_server_test.rs	100.00%	26 / 26
libcoap/tests/dtls_rpk_client_server_test.rs	100.00%	7 / 7
libcoap/tests/tcp_client_server_test.rs	100.00%	22 / 22
libcoap/tests/udp_client_server_test.rs	100.00%	22 / 22

Total coverage: 54.77%

[falko17]

Only one small comment, so I'll approve already.