-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compile-time and runtime checks for feature availability #26
Conversation
503c43f
to
25db012
Compare
Workflow Status ReportGenerated for commit 9cf7cd3 on Thu Aug 22 14:04:26 UTC 2024. Linting ReportClippy check result: success Refer to the "Files Changed" tab for identified issues. Code Coverage Report
Diff against main
Results for commit: 4eb5188 Coverage target is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See a couple of comments below, otherwise looks pretty good to me :)
Co-authored-by: Jan Romann <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! :)
…ut feature checks)
Co-authored-by: Jan Romann <[email protected]>
76330de
to
4eb5188
Compare
This PR adds startup and compile-time checks to
libcoap-rs
andlibcoap-sys
that ensure that features enabled byCargo.toml
are actually available.This is now possible thanks to the changes made in obgm/libcoap#1488, which adds the required defines for compile-time and functions for startup checks.
Closes #20