(WIP) Rework of DTLS code, add DTLS PKI/RPK #161
Triggered via pull request
September 11, 2024 18:14
Status
Failure
Total duration
2m 47s
Artifacts
–
Annotations
4 errors and 11 warnings
lint (libcoap-rs)
reviewdog exited with status code: 1
|
coverage
Process completed with exit code 1.
|
test (libcoap-rs, tinydtls)
Process completed with exit code 101.
|
test (libcoap-rs, openssl)
Process completed with exit code 101.
|
[clippy (libcoap-rs)] libcoap/src/crypto/psk/client.rs#L71:
libcoap/src/crypto/psk/client.rs#L71
warning: use of `.then_some(..).unwrap_or(..)` can be written more clearly with `if .. else ..`
--> libcoap/src/crypto/psk/client.rs:71:37
|
71 | self.ctx.raw_cfg.ec_jpake = ec_jpake.then_some(1).unwrap_or(0);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if ec_jpake { 1 } else { 0 }`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#obfuscated_if_else
= note: `#[warn(clippy::obfuscated_if_else)]` on by default
|
[clippy (libcoap-rs)] libcoap/src/crypto/psk/client.rs#L77:
libcoap/src/crypto/psk/client.rs#L77
warning: use of `.then_some(..).unwrap_or(..)` can be written more clearly with `if .. else ..`
--> libcoap/src/crypto/psk/client.rs:77:36
|
77 | self.ctx.raw_cfg.use_cid = use_cid.then_some(1).unwrap_or(0);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if use_cid { 1 } else { 0 }`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#obfuscated_if_else
|
[clippy (libcoap-rs)] libcoap/src/crypto/psk/client.rs#L231:
libcoap/src/crypto/psk/client.rs#L231
warning: derefed type is same as origin
--> libcoap/src/crypto/psk/client.rs:231:39
|
231 | if identity_hint.is_none() || key.identity().as_deref() == identity_hint {
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `key.identity()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref
= note: `#[warn(clippy::needless_option_as_deref)]` on by default
|
[clippy (libcoap-rs)] libcoap/src/crypto/psk/key.rs#L127:
libcoap/src/crypto/psk/key.rs#L127
warning: casting the result of `from_raw_parts_mut` to *mut [u8]
--> libcoap/src/crypto/psk/key.rs:127:43
|
127 | let data = unsafe { Box::from_raw(std::slice::from_raw_parts_mut(key.s as *mut u8, key.length) as *mut [u8]) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `core::ptr::slice_from_raw_parts_mut(key.s as *mut u8, key.length)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_slice_from_raw_parts
= note: `#[warn(clippy::cast_slice_from_raw_parts)]` on by default
|
[clippy (libcoap-rs)] libcoap/src/crypto/psk/key.rs#L136:
libcoap/src/crypto/psk/key.rs#L136
warning: useless conversion to the same type: `std::boxed::Box<[u8]>`
--> libcoap/src/crypto/psk/key.rs:136:19
|
136 | data: value.into(),
| ^^^^^^^^^^^^ help: consider removing `.into()`: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
[clippy (libcoap-rs)] libcoap/src/crypto/psk/server.rs#L75:
libcoap/src/crypto/psk/server.rs#L75
warning: use of `.then_some(..).unwrap_or(..)` can be written more clearly with `if .. else ..`
--> libcoap/src/crypto/psk/server.rs:75:37
|
75 | self.ctx.raw_cfg.ec_jpake = ec_jpake.then_some(1).unwrap_or(0);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if ec_jpake { 1 } else { 0 }`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#obfuscated_if_else
|
[clippy (libcoap-rs)] libcoap/src/crypto/psk/server.rs#L236:
libcoap/src/crypto/psk/server.rs#L236
warning: derefed type is same as origin
--> libcoap/src/crypto/psk/server.rs:236:23
|
236 | .find(|k| k.identity().as_deref().is_some_and(|kid| kid == identity))
| ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `k.identity()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref
|
[clippy (libcoap-rs)] libcoap/src/crypto/psk/server.rs#L255:
libcoap/src/crypto/psk/server.rs#L255
warning: this call to `as_ref` does nothing
--> libcoap/src/crypto/psk/server.rs:255:20
|
255 | let keys = self.as_ref();
| ^^^^^^^^^^^^^ help: try: `self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
= note: `#[warn(clippy::useless_asref)]` on by default
|
[clippy (libcoap-rs)] libcoap/src/types.rs#L761:
libcoap/src/types.rs#L761
warning: using `libc::strlen` on a `CString` or `CStr` value
--> libcoap/src/types.rs:761:17
|
761 | libc::strlen(uri.uri_str.0.as_ptr()),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `uri.uri_str.0.as_bytes().len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#strlen_on_c_strings
= note: `#[warn(clippy::strlen_on_c_strings)]` on by default
|
lint (libcoap-sys)
The following actions use a deprecated Node.js version and will be forced to run on node20: giraffate/clippy-action@main. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
lint (libcoap-rs)
The following actions use a deprecated Node.js version and will be forced to run on node20: giraffate/clippy-action@main. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|