-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ponder-ens): introduce plugin architecture #3
Merged
Merged
Changes from 2 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
dcc37b3
feat(ponder-ens): introduce plugin architecture
tk-o a5bfb00
feat(ponder-ens-plugin): update abis and contract configs
tk-o 2578b0f
fix(ens-base-plugin): enalbe domain insert setup event
tk-o fae9508
feat(ponder-ens-plugin): include early adopter registrar contract
tk-o e1dad39
feat(ponder-ens-plugin): focus plugins around domain names
tk-o 1931ec7
checkpoint: pull shared logic for registry and resolvers into shared …
shrugs 3d181f9
feat: refactor plugin logic, DRY handler code
shrugs 2d079a7
chore: inline some addreses
shrugs 32912d5
refactor: DRY up registrar code
shrugs 7f84cff
Merge pull request #4 from namehash/refactor/plugin-logic
shrugs a88933e
feat(ponder-ens-plugin): use domain name path as a namespace
tk-o 7e5af0e
chore(ponder-ens-plugin): use biomejs formatter
tk-o cd152a6
fix: tidy registrar handlers
shrugs dc0bfdd
fix: handle preminted domain in base node
shrugs 77c1ec2
fix(base.eth): handle `NameRegisteredWithRecord` event
tk-o ff0b2af
fix(deps): update ponder version
tk-o b3c17e5
fix: use selected root domain name
tk-o 0e35dd8
refactor: rename consts to apply feedback
tk-o e5d7541
docs(base.eth): update readme
tk-o 067f570
refactor(ponder-plugins): simplify architecture
tk-o e3b62c0
refactor(ponder-plugins): use `managed subname` term
tk-o aad651c
refactor(ponder-plugins): make generic handlers to use ponder types
tk-o 00c9935
chore(code-style): apply `biome format --fix`
tk-o a39200f
fix(ci): run static analysis
tk-o 9eb9eef
refactor(plugins): rename plugins directory
tk-o 728ec62
refactor(plugins): rename plugin helpers
tk-o 7c4bc1e
refactor(plugins): rename plugin helpers file
tk-o 9891ed0
refactor(plugins): rename ponder plugins to just plugins
tk-o 7b81161
refactor(plugins): drop the ACTIVE_PLUGIN env var parser
tk-o 1dbe2a9
refactor(plugins): use `ownedSubname` name
tk-o cc6f2c3
refactor(plugins): rename `ownedSubname` to `ownedName`
tk-o File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
# RPC urls, follow the format RPC_URL_{chainId}={rpcUrl} | ||
|
||
PONDER_RPC_URL_1=https://ethereum-rpc.publicnode.com | ||
PONDER_RPC_URL_8453=https://base-rpc.publicnode.com | ||
PONDER_RPC_URL_59144=https://linea-rpc.publicnode.com | ||
|
||
# ponder indexer ens deployment configuration | ||
|
||
ENS_DEPLOYMENT_CHAIN_ID=1 | ||
|
||
# ponder indexer database configuration | ||
|
||
## one schema name per chain ID, i.e. ponder_ens_${ENS_DEPLOYMENT_CHAIN_ID} | ||
DATABASE_SCHEMA=ponder_ens_1 | ||
DATABASE_URL=postgresql://dbuser:abcd1234@localhost:5432/my_database |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,25 @@ | ||
import { createConfig } from "ponder"; | ||
import { config as ethereumConfig} from "./src/ponder-ens-plugins/ethereum/ponder.config"; | ||
import { config as baseConfig } from "./src/ponder-ens-plugins/base/ponder.config"; | ||
import { config as ethereumConfig } from "./src/ponder-ens-plugins/ethereum/ponder.config"; | ||
|
||
console.log({ | ||
networks: { | ||
...baseConfig.networks, | ||
...ethereumConfig.networks, | ||
}, | ||
contracts: { | ||
...baseConfig.contracts, | ||
...ethereumConfig.contracts, | ||
}, | ||
}) | ||
|
||
export default createConfig({ | ||
tk-o marked this conversation as resolved.
Show resolved
Hide resolved
|
||
networks: { | ||
...baseConfig.networks, | ||
...ethereumConfig.networks, | ||
}, | ||
contracts: { | ||
...baseConfig.contracts, | ||
...ethereumConfig.contracts, | ||
}, | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
# Base ENS plugin for Ponder indexer | ||
tk-o marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
This plugin contains configuration required to run blockchain indexing with [the Ponder app](https://ponder.sh/). It includes relevant ABI files, contract addresses and the block numbers those contracts were deployed at on a selected network. | ||
|
||
## Architecture | ||
|
||
The Base implementation for ENS protocol has custom naming convention, which was described here: | ||
tk-o marked this conversation as resolved.
Show resolved
Hide resolved
|
||
https://github.com/base-org/basenames?tab=readme-ov-file#architecture | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please add more docs here? For example? Does this value always need to be a single value, or can it be multiple values? If it can be multiple values, how to format it? It can also be nice to document which values are supported here or perhaps in the overall README.md.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tk-o This is still an open feedback