feat(cross-chain-indexing): enable multiple concurrent plugins #24

tk-o · 2025-01-13T20:10:59Z

For example. with this change, it's possible to get a list of all names a given address owns across multiple chains (i.e. base.eth subnames on Base, and linea.eth subnames on Linea.

Example query

query GetOwnedDomains($ownerAddreess: String!) {
  domains(
    where: {OR: [{ownerId: $ownerAddreess}, {wrappedOwnerId: $ownerAddreess}]}
  ) {
    items {
      labelName
      name
      ownerId
      wrappedOwnerId
      createdAt
      expiryDate
    }
  }
}

Preview

Domain names under eth, base.eth, and linea.eth:

This PR overrides:

feat(cross-subname-indexing): allow activating multiple plugins together #21

…xing

.env.local.example

ponder.config.ts

src/handlers/Registrar.ts

src/handlers/Registry.ts

src/plugins/base.eth/handlers/Registrar.ts

src/lib/helpers.ts

lightwalker-eth

@tk-o Super updates 👍 Reviewed and shared feedback 🙌

.env.local.example

ponder.config.ts

src/plugins/base.eth/handlers/Registrar.ts

src/plugins/linea.eth/handlers/EthRegistrar.ts

src/handlers/Registry.ts

Apply PR suggestion regarding the in-code documentation Co-authored-by: lightwalker.eth <[email protected]>

Create an idepotenet function that takes a domain token ID and makes sure there is a database entity created for it.

lightwalker-eth

@tk-o Thanks for updates 👍 Reviewed and shared a few more points of feedback.

.env.local.example

src/lib/upserts.ts

src/handlers/Registry.ts

src/plugins/base.eth/handlers/Registrar.ts

… -m "Had to replace `.onConflictDoNothing()` with `.onConflictDoUpdate({})` as the former would not return a DB entity if there was a conflict. The later would apply the delta on conflict, but since delta is an empty object, there will be no update at all. And yet, the existing DB entity will be always returned."

Declare all plugins active with the default `ACTIVE_PLUGINS` env var.

lightwalker-eth

@tk-o Hey nice updates, thanks. Just very minor nitpicks 👍

src/handlers/Registry.ts

src/lib/helpers.ts

Co-authored-by: lightwalker.eth <[email protected]>

lightwalker-eth

@tk-o Thanks for updates. I made one last end-to-end review of the PR (rather than just reviewing the incremental changes since a prior review).

Let's do a great job on all the details. Thanks!

src/handlers/Registry.ts

src/lib/helpers.ts

src/lib/plugin-helpers.ts

lightwalker-eth · 2025-01-17T14:48:56Z

src/plugins/base.eth/handlers/Registrar.ts

 export default function () {
  // support NameRegisteredWithRecord for BaseRegistrar as it used by Base's RegistrarControllers
  ponder.on(pluginNamespace("BaseRegistrar:NameRegisteredWithRecord"), async ({ context, event }) =>
    handleNameRegistered({ context, event }),
  );

  ponder.on(pluginNamespace("BaseRegistrar:NameRegistered"), async ({ context, event }) => {
+    await upsertAccount(context, event.args.owner);


@tk-o Thanks for the background info.

I'm still not clear here however.

The reason why is because I see the call to handleNameRegistered at the end of this function. My understanding is that handleNameRegistered will perform this upsertAccount to match the subgraph equivalency you linked in your reply above.

So my question is still open: Why are we calling upsertAccount again here?

src/plugins/base.eth/handlers/Registrar.ts

src/handlers/Registry.ts

src/lib/helpers.ts

lightwalker-eth

@tk-o Very close. Getting there 😄 A few more feedbacks.

src/plugins/linea.eth/handlers/EthRegistrar.ts

lightwalker-eth · 2025-01-17T16:36:18Z

src/plugins/base.eth/handlers/Registrar.ts

 export default function () {
  // support NameRegisteredWithRecord for BaseRegistrar as it used by Base's RegistrarControllers
  ponder.on(pluginNamespace("BaseRegistrar:NameRegisteredWithRecord"), async ({ context, event }) =>
    handleNameRegistered({ context, event }),
  );

  ponder.on(pluginNamespace("BaseRegistrar:NameRegistered"), async ({ context, event }) => {
+    await upsertAccount(context, event.args.owner);


@tk-o This is still an open question for me. Can you please clarify?

src/plugins/base.eth/handlers/Registrar.ts

src/lib/plugin-helpers.ts

ponder.config.ts

lightwalker-eth

@tk-o All now looks good to me 🚀 @shrugs we created a separate follow up question for you here that we can follow up on outside of this PR if you like: #34

@shrugs Please take the lead on reviewing this PR and merging it in when it looks good to you 👍

shrugs

LGTM, merging

shrugs · 2025-01-17T21:42:34Z

src/plugins/base.eth/handlers/Registrar.ts

 export default function () {
  // support NameRegisteredWithRecord for BaseRegistrar as it used by Base's RegistrarControllers
  ponder.on(pluginNamespace("BaseRegistrar:NameRegisteredWithRecord"), async ({ context, event }) =>
    handleNameRegistered({ context, event }),
  );

  ponder.on(pluginNamespace("BaseRegistrar:NameRegistered"), async ({ context, event }) => {
+    await upsertAccount(context, event.args.owner);


correct.

side note: ponder doesn't enforce foreign key constraints in the postgres schema, so technically either order works but we should prefer the order you've suggested here, since domain records should depend on account record existing.

tk-o added 9 commits January 12, 2025 08:53

feat(cross-subname-indexing): allow activating multiple plugins together

618e8d3

feat(cross-subname-indexing): demonstrate retrieving cross-subname index

7d8f978

refactor(handlers): stremline logic

76754e4

refactor(ponder.config): simplify structure

0ffa78c

fix: apply pr feedback

b118dfb

fix: typos

c71479f

fix: apply pr feedback

ceb03cc

feat(plugins): introduce ACTIVE_PLUGINS validation

fa57a34

Merge remote-tracking branch 'origin/main' into feat/cross-chain-inde…

3b2c07b

…xing

tk-o mentioned this pull request Jan 13, 2025

feat(cross-subname-indexing): allow activating multiple plugins together #21

Closed

tk-o commented Jan 13, 2025

View reviewed changes

.env.local.example Show resolved Hide resolved

tk-o commented Jan 13, 2025

View reviewed changes

ponder.config.ts Show resolved Hide resolved

tk-o commented Jan 13, 2025

View reviewed changes

ponder.config.ts Outdated Show resolved Hide resolved

tk-o commented Jan 13, 2025

View reviewed changes

src/handlers/Registrar.ts Show resolved Hide resolved

tk-o commented Jan 13, 2025

View reviewed changes

src/handlers/Registry.ts Show resolved Hide resolved

tk-o commented Jan 13, 2025

View reviewed changes

src/plugins/base.eth/handlers/Registrar.ts Outdated Show resolved Hide resolved

tk-o added 2 commits January 13, 2025 21:27

fix(schema): use proper schema import

748dfa4

feat(utils): import deep merge npm lib

5365dd6

tk-o commented Jan 13, 2025

View reviewed changes

src/lib/helpers.ts Show resolved Hide resolved

fix(codestyle): apply formatting

43b1dc7

lightwalker-eth requested changes Jan 14, 2025

View reviewed changes

tk-o and others added 2 commits January 14, 2025 14:05

docs: apply text edits

ac141f5

Apply PR suggestion regarding the in-code documentation Co-authored-by: lightwalker.eth <[email protected]>

feat(database-entites): ensure domain entity exists

46ab32d

Create an idepotenet function that takes a domain token ID and makes sure there is a database entity created for it.

lightwalker-eth requested changes Jan 14, 2025

View reviewed changes

tk-o added 6 commits January 14, 2025 15:56

docs: update description of ensureDomainExists

5e1b695

fix(defaults): make all available plugins active

f63ba6a

Declare all plugins active with the default `ACTIVE_PLUGINS` env var.

feat(deps): update ponder

8d2bb1b

docs(handlers): update Registry descriptions

c478ad5

fix(handlers-base.eth): remove dead code

6e19c7d

tk-o added 7 commits January 17, 2025 05:57

refactor(helpers): update rpcRequestRateLimit config facotry

7a7a70b

docs: typos

a42be85

docs(helpers): move the docs around

03529a3

refactor(ponder.config): renames

19394cb

docs(handlers): update registry setup description

b0575f5

docs: replacements

141e57c

feat(helpers): introduce rpcEndpointUrl factory

77cc78b

railway-app bot temporarily deployed to alpha January 17, 2025 05:38 Inactive

fix(codestyle): apply auto-formatting

f35a828

railway-app bot temporarily deployed to alpha January 17, 2025 05:41 Inactive

lightwalker-eth changed the title ~~feat(cross-chain-indexing): enable multiple plugins in one go~~ feat(cross-chain-indexing): enable multiple concurrent plugins Jan 17, 2025

lightwalker-eth requested changes Jan 17, 2025

View reviewed changes

src/handlers/Registry.ts Outdated Show resolved Hide resolved

src/handlers/Registry.ts Outdated Show resolved Hide resolved

src/lib/helpers.ts Outdated Show resolved Hide resolved

src/lib/helpers.ts Outdated Show resolved Hide resolved

src/lib/helpers.ts Outdated Show resolved Hide resolved

docs: update descriptions

7d060be

Co-authored-by: lightwalker.eth <[email protected]>

railway-app bot temporarily deployed to alpha January 17, 2025 14:27 Inactive

fix(helpers): update env var parsing logic

b3f5146

lightwalker-eth requested changes Jan 17, 2025

View reviewed changes

docs: being more specific and correct

4b586eb

railway-app bot temporarily deployed to alpha January 17, 2025 15:57 Inactive

railway-app bot temporarily deployed to alpha January 17, 2025 16:03 Inactive

fix(plugin-helpers): rename types

a7099a4

railway-app bot temporarily deployed to alpha January 17, 2025 16:36 Inactive

lightwalker-eth requested changes Jan 17, 2025

View reviewed changes

tk-o added 2 commits January 17, 2025 18:26

fix: apply pr feedback

b7704f4

docs: update env example

ba17d36

railway-app bot temporarily deployed to alpha January 17, 2025 17:49 Inactive

lightwalker-eth mentioned this pull request Jan 17, 2025

upsertAccount in base.eth Registrar handler #34

Closed

lightwalker-eth approved these changes Jan 17, 2025

View reviewed changes

shrugs approved these changes Jan 17, 2025

View reviewed changes

shrugs merged commit a2f3ce2 into main Jan 17, 2025
1 of 2 checks passed

shrugs deleted the feat/cross-chain-indexing branch January 17, 2025 21:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(cross-chain-indexing): enable multiple concurrent plugins #24

feat(cross-chain-indexing): enable multiple concurrent plugins #24

tk-o commented Jan 13, 2025 •

edited

Loading

lightwalker-eth left a comment

lightwalker-eth left a comment

lightwalker-eth left a comment

lightwalker-eth left a comment

lightwalker-eth Jan 17, 2025

lightwalker-eth left a comment

lightwalker-eth Jan 17, 2025

lightwalker-eth left a comment

shrugs left a comment

shrugs Jan 17, 2025

feat(cross-chain-indexing): enable multiple concurrent plugins #24

feat(cross-chain-indexing): enable multiple concurrent plugins #24

Conversation

tk-o commented Jan 13, 2025 • edited Loading

Example query

Preview

lightwalker-eth left a comment

Choose a reason for hiding this comment

lightwalker-eth left a comment

Choose a reason for hiding this comment

lightwalker-eth left a comment

Choose a reason for hiding this comment

lightwalker-eth left a comment

Choose a reason for hiding this comment

lightwalker-eth Jan 17, 2025

Choose a reason for hiding this comment

lightwalker-eth left a comment

Choose a reason for hiding this comment

lightwalker-eth Jan 17, 2025

Choose a reason for hiding this comment

lightwalker-eth left a comment

Choose a reason for hiding this comment

shrugs left a comment

Choose a reason for hiding this comment

shrugs Jan 17, 2025

Choose a reason for hiding this comment

tk-o commented Jan 13, 2025 •

edited

Loading