feat(plugin): index linea.eth #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk-o
commented
Jan 9, 2025
| @@ -48,7 +48,7 @@ export function createPluginNamespace<Subname extends string>(subname: Subname) | |||
| } | |||
|
|
|||
| type TransformNameIntoPath<Name extends string> = Name extends `${infer Sub}.${infer Rest}` | |||
| ? `/${TransformNameIntoPath<Rest>}/${Sub}` | |||
| ? `${TransformNameIntoPath<Rest>}/${Sub}` | |||
There was a problem hiding this comment.
This is a bugfix, as without it, the type would always start with a double slash. We need a single slash.
There was a problem hiding this comment.
@tk-o Nice, thanks for catching this 👍
What do you think about creating an issue for us to action in a future PR? The issue would be to add vitest to the project and to define some initial unit tests.
There was a problem hiding this comment.
Recorded your request here:
tk-o
commented
Jan 9, 2025
| - name: Install dependencies | ||
| run: pnpm install | ||
|
|
||
| - name: Run Biome CI | ||
| run: pnpm biome ci | ||
|
|
||
| - name: Run TypeScript type checking | ||
| run: pnpm run typecheck |
There was a problem hiding this comment.
I accidentally broke the eth plugin while making changes to handlers files to enable linea.eth integration. This CI step will notify me if I do a similar mistake in the future.
shrugs
reviewed
Jan 9, 2025
src/handlers/NameWrapper.ts
Outdated
| node: Hex; | ||
| fuses: number; | ||
| }; | ||
| export const makeRegistryHandlers = (ownedName: `${string}eth`) => { |
shrugs
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of
and needs to be only merged afterwards.
The PR introduces the
linea.ethplugin for Ponder indexer. Thelinea.ethplugin is very similar to theethplugin. We can say it extends it (with minor naming alterations in some interfaces).