face: handle PcapHelper::Error when applying multicast configuration

When the network interface state is changed, NFD reconfigures its
multicast ethernet faces. The code responsible for this is prone to
a TOCTOU race condition, e.g., if an interface is quickly brought up
and then down again. This currently raises an uncaught exception when
we try to set a packet filter for that interface.

Prevent this issue by catching PcapHelper errors in the same manner
as we catch EthernetTransport errors, and skip creating the face.

Refs: #5297
Change-Id: I9f91ac7c42dec06de34128cb34d6de8bb57e8cf5

.mailmap

@@ -1,14 +1,16 @@
 <[email protected]> <[email protected]>
+Alexander Lane <[email protected]>
+<[email protected]> <[email protected]>
 <[email protected]> <[email protected]>
 <[email protected]> <[email protected]>
-Vince Lehman <[email protected]> <[email protected]>
-<[email protected]> <[email protected]>
-Hila Ben Abraham <[email protected]>
-<[email protected]> <[email protected]>
 Haowei Yuan <[email protected]>
+Hila Ben Abraham <[email protected]>
+<[email protected]> <[email protected]>
+Md Ashiqur Rahman <[email protected]>
 Minsheng Zhang <[email protected]>
 Spyridon Mastorakis <[email protected]>
-Md Ashiqur Rahman <[email protected]>
-Yumin Xia <[email protected]>
-<[email protected]> <[email protected]>
+Susmit Shannigrahi <[email protected]>
 Tai-Lin Chu <[email protected]>
+<[email protected]> <[email protected]>
+Vince Lehman <[email protected]> <[email protected]>
+Yumin Xia <[email protected]>

daemon/face/ethernet-factory.cpp

@@ -26,6 +26,7 @@
 #include "ethernet-factory.hpp"
 #include "generic-link-service.hpp"
 #include "multicast-ethernet-transport.hpp"
+#include "pcap-helper.hpp"
 
 #include <boost/range/adaptors.hpp>
 #include <boost/range/algorithm/copy.hpp>
@@ -337,6 +338,10 @@ EthernetFactory::applyMcastConfigToNetif(const ndn::net::NetworkInterface& netif
     NFD_LOG_WARN("Cannot create multicast face on " << netif.getName() << ": " << e.what());
     return nullptr;
   }
+  catch (const PcapHelper::Error& e) {
+    NFD_LOG_WARN("Cannot create multicast face on " << netif.getName() << ": " << e.what());
+    return nullptr;
+  }
 
   if (face->getId() == INVALID_FACEID) {
     // new face: register with forwarding