Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove v prefix in CI_VERSION #188

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Remove v prefix in CI_VERSION #188

merged 1 commit into from
Aug 8, 2023

Conversation

sitiom
Copy link
Contributor

@sitiom sitiom commented Jul 26, 2023

DisplayVersion should not contain the v prefix. See #82 (comment)

@namazso
Copy link
Owner

namazso commented Jul 26, 2023

I'm pretty sure the linked issue was an issue in winget metadata. Windows apps have both numeric and string versions, and the numeric ones do not contain the v. It was also fixed on winget side since:

image

Is there any point to this change that I fail to notice?

@sitiom
Copy link
Contributor Author

sitiom commented Jul 26, 2023

I'm pretty sure the linked issue was an issue in winget metadata. Windows apps have both numeric and string versions, and the numeric ones do not contain the v. It was also fixed on winget side since:

image

Is there any point to this change that I fail to notice?

It's unusual for a package to include the v prefix in the PackageVersion, and is usually trimmed away and matches the DisplayVersion in the installed apps section:

image

However, the DisplayVersion here also doesn't trim the v prefix as well (which is also not usual). This change fixes it, much like with the 2.x versions:

image

@namazso
Copy link
Owner

namazso commented Jul 26, 2023

Hm.. Will this not break the currently working winget stuff either? I guess not because the previous issue was with 2.x overriding v3.x so it will just accidentally work. Unless winget code was changed to accomodate the v

I also plan to switch to WiX 4 and MSIX for distribution (hence the deprecation notice for <1909) so stuff might change over installation version mess too.

@sitiom
Copy link
Contributor Author

sitiom commented Jul 26, 2023

Hm.. Will this not break the currently working winget stuff either? I guess not because the previous issue was with 2.x overriding v3.x so it will just accidentally work.

Yeah, I guess that would be the case. The previous 2.x versions can then be brought back in Winget (for completeness if someone likes to)

@namazso namazso merged commit afb8489 into namazso:master Aug 8, 2023
@sitiom sitiom deleted the version branch August 8, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants