Skip to content

Commit

Permalink
fix: add missing Java import for @Valid annotation
Browse files Browse the repository at this point in the history
- Add missing annotation
- Update tests

Resolves asyncapi#2175

Signed-off-by: Esta Nagy <[email protected]>
  • Loading branch information
nagyesta committed Feb 8, 2025
1 parent d37432b commit 33752cf
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
3 changes: 3 additions & 0 deletions src/generators/java/presets/ConstraintsPreset.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ export const JAVA_CONSTRAINTS_PRESET: JavaPreset<JavaConstraintsPresetOptions> =
renderer.dependencyManager.addDependency(
`import ${importFrom}.validation.constraints.*;`
);
renderer.dependencyManager.addDependency(
`import ${importFrom}.validation.Valid;`
);
return content;
},
// eslint-disable-next-line sonarjs/cognitive-complexity
Expand Down
9 changes: 6 additions & 3 deletions test/generators/java/presets/ConstraintsPreset.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ describe('JAVA_CONSTRAINTS_PRESET', () => {
const generator = new JavaGenerator({ presets: [JAVA_CONSTRAINTS_PRESET] });
const expectedDependencies = [
'import java.util.Map;',
'import javax.validation.constraints.*;'
'import javax.validation.constraints.*;',
'import javax.validation.Valid;'
];

const models = await generator.generate(doc);
Expand All @@ -46,7 +47,8 @@ describe('JAVA_CONSTRAINTS_PRESET', () => {
});
const expectedDependencies = [
'import java.util.Map;',
'import javax.validation.constraints.*;'
'import javax.validation.constraints.*;',
'import javax.validation.Valid;'
];

const models = await generator.generate(doc);
Expand All @@ -68,7 +70,8 @@ describe('JAVA_CONSTRAINTS_PRESET', () => {
});
const expectedDependencies = [
'import java.util.Map;',
'import jakarta.validation.constraints.*;'
'import jakarta.validation.constraints.*;',
'import jakarta.validation.Valid;'
];

const models = await generator.generate(doc);
Expand Down

0 comments on commit 33752cf

Please sign in to comment.