Fancy dicts #9
Open
Fancy dicts #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, can you please rebase this? |
|
This is rebased now, but I haven't tested it yet. |
|
The problem with this will probably, that backup files will not be converted to |
|
It would be really cool, if it would be possible, to change the used dict in the config. And if it will be created on startup, so the database does not need to change. I do not know how this will be possible, but I hope that you have an idea, how to implement that :) . |
|
We could serialize the fancy dicts into normal dicts and either do a post-processing after load to turn the normal dict into the fancy one, or provide yaml with some sort of factory function. Are the accounts currently saved as a list or as a dict? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using fancy dicts as suggested in #8
it should be possible to simply exchange NormalizingDict with FuzzyDict to introduce levenshtein #4 for keeping the accounts in group.